Uh oh!
There was an error while loading. Please reload this page.
base_fw: add DMI_FORCE_L1_EXIT FW config (depends on Zephyr 66042) - #8561
Conversation
Uh oh!
There was an error while loading. Please reload this page.
kv2019i
left a comment
There was a problem hiding this comment.
Thanks, SOF side looks good, but Zephyr side PR needs to pass and be merged first.
Uh oh!
There was an error while loading. Please reload this page.
5c3955d to
25866d9Compare2ebbfb3 to
8d311efComparekv2019i
left a comment
There was a problem hiding this comment.
I'm afraid we have multiple build errors for "lnl" and "tgl". We need a fixup to Zephyr upstream, it seems the L1_EXIT define is not available for lnl and for "tgl" inclusion of adsp_shim.h is causing problems.
8d311ef to
103910eComparekv2019i
left a comment
There was a problem hiding this comment.
Zephyr PR is now good and lnl compiles but still some issues on the SOF side changes, please see inline (and CI results).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
3b52b65 to
f10fb9cCompareintel_adsp: lnl: add missing definition for lnl 28d5d23a232b69b213112e723e0a6392cbd5a47e Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
e3742d3 to
f34fc81Comparekv2019i
commented
Dec 18, 2023
@fkwasowi The tgl/tgl-h still seems to fail, can you check: |
f34fc81 to
1fca404Comparekv2019i
left a comment
There was a problem hiding this comment.
Code looks good now. One suggestion about how to handle platforms that do not support this feature. I wonder if return an error would be more future-proof, but this is not blocking issue to me.
| if (force) { | ||
| tr_info(&basefw_comp_tr, "FW config set force dmi l0 state"); | ||
| #if defined(CONFIG_SOC_SERIES_INTEL_ACE) |
There was a problem hiding this comment.
Not sure what to return if the functionality is not available. Alternatively you could #ifdef the whole funciton body and at the end:
#if defined(CONFIG_SOC_SERIES_INTEL_ACE)
const uint32_t force = ..
...
#else
return IPC4_UNAVAILABLE;
#endif
Add new parameter for SW to force DMI L1 exit on IPC request. Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
1fca404 to
7f63e55Compare
Add new parameter for SW to force DMI L1 exit on IPC request.
Associated with: zephyrproject-rtos/zephyr#66042
Separating two new functions force and allow l1 to have the current state with separated functions in the power manager so that SOF can call these functions via IPC DMI_FORCE_L1_EXIT. DMA sometimes slows down and does not perform, therefore the workaround is to switch off l1. Change related to the addition of a new parameter to force DMI L1 exit on IPC request.