Skip to content

xtensa-build-zephyr.py: Re-add imx8ulp to -all - #8584

Merged
dbaluta merged 1 commit into
thesofproject:mainfrom
dbaluta:re_add_imx8ulp
Dec 14, 2023
Merged

xtensa-build-zephyr.py: Re-add imx8ulp to -all#8584
dbaluta merged 1 commit into
thesofproject:mainfrom
dbaluta:re_add_imx8ulp

Conversation

@dbaluta

@dbalutadbaluta commented Dec 6, 2023

Copy link
Copy Markdown
Collaborator

This re-adds imx8ulp to --all platform list. This was removed in commit 7737efa ("xtensa-build-zephyr.py: remove imx8ulp from --all")

@dbaluta
xtensa-build-zephyr.py: Re-add imx8ulp to -all
1d5b8f4
This re-adds imx8ulp to --all platform list. This was removed
in commit 7737efa ("xtensa-build-zephyr.py: remove imx8ulp from --all")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta
dbaluta requested a review from marc-hb as a code ownerDecember 6, 2023 16:01
@dbalutadbaluta changed the title xtensa-build-zephyr.py: Re-add imx8ulp to -all[DNM] xtensa-build-zephyr.py: Re-add imx8ulp to -allDec 6, 2023
@dbaluta
dbaluta marked this pull request as draft December 6, 2023 16:01
@dbaluta

dbaluta commented Dec 6, 2023

Copy link
Copy Markdown
CollaboratorAuthor

We can merge this after #8582 gets in.

@marc-hb

marc-hb commented Dec 8, 2023

Copy link
Copy Markdown
Collaborator

This still won't build it in CI, you need to extend the list in .github/workflows/zephyr.yml. See commit a114c45

@dbaluta
dbaluta marked this pull request as ready for review December 8, 2023 13:25
@dbalutadbaluta changed the title [DNM] xtensa-build-zephyr.py: Re-add imx8ulp to -allxtensa-build-zephyr.py: Re-add imx8ulp to -allDec 8, 2023
@dbaluta

dbaluta commented Dec 8, 2023•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

@marc-hb thanks for pointing out.

I've created this : #8596

... but I do have the feeling that I need to also update zephyr-sdk to include imx8ulp toolchain.

Indeed we need to upgrade zephyr sdk from zephyr-sdk-0.16.1 -> zephyr-sdk-0.16.4

Can someone at Intel help with this?

@marc-hb

marc-hb commented Dec 8, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

Indeed we need to upgrade zephyr sdk from zephyr-sdk-0.16.1 -> zephyr-sdk-0.16.4

Can someone at Intel help with this?

There should be only two numbers to bump:

Can you please try? (in a separate PR). It's a minor upgrade so there's a chance things will just work.

@marc-hbmarc-hb mentioned this pull request Dec 8, 2023
Merged
@dbaluta

dbaluta commented Dec 13, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Can you please try? (in a separate PR). It's a minor upgrade so there's a chance things will just work.

Let's watch this and see what happens: #8618

@dbaluta
dbaluta merged commit af3fa41 into thesofproject:mainDec 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019ikv2019ikv2019i approved these changes
@iuliana-prodaniuliana-prodaniuliana-prodan approved these changes
@marc-hbmarc-hbAwaiting requested review from marc-hb
@LaurentiuM1234LaurentiuM1234Awaiting requested review from LaurentiuM1234

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbaluta@marc-hb@kv2019i@iuliana-prodan