Uh oh!
There was an error while loading. Please reload this page.
ipc4: Regression FIX: Do not clear sources/sinks on reset - #8657
Conversation
After thesofproject#8594 been merged, sources and sinks are now setup on .bind() and .unbind(). Previously they were setup in .prepare(). However, there were code left in module_adapter_reset() which clears sources and sinks arrays. That broke some tests: modules which use source/sink API stopped working correctly after pipeline reset. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
marcinszkudlinski
commented
Dec 20, 2023
good point, |
serhiy-katsyuba-intel
commented
Dec 20, 2023
They are re-setup (overwritten) at .bind() and .unbind(). So, yes, if something been unbinded then num_of_sources/num_of_sinks and sources[]/sinks[] will be updated appropriately. |
serhiy-katsyuba-intel
commented
Dec 20, 2023
Internal Intel CI has failed on tests checkout. Been re-scheduled to run again. |
kv2019i
left a comment
There was a problem hiding this comment.
Didn't realize immediately that we call the prepare function at unbind as well, so indeed this piece of code is not needed.
lgirdwood
commented
Dec 21, 2023
@serhiy-katsyuba-intel any update on CI ? Fwiw, there was an DUT upload issue last night that blocked some PRs so worth checking if this is good to merge. |
serhiy-katsyuba-intel
commented
Dec 21, 2023
@lgirdwood , @kv2019i , CI finally completed. Ready to merge. |
After #8594 been merged, sources and sinks are now setup on .bind() and .unbind(). Previously they were setup in .prepare(). However, there were code left in module_adapter_reset() which clears sources and sinks arrays. That broke some tests: modules which use source/sink API stopped working correctly after pipeline reset.