Uh oh!
There was an error while loading. Please reload this page.
Remove sof logging ctx - #8725
Closed
btian1 wants to merge 1 commit into
Closed
Conversation
btian1
commented
Jan 15, 2024
ContributorAuthor
@dbaluta@iuliana-prodan , could you help check from IPC3 side? as this change only have impact on IPC3 and I don't have a way to check. |
dbaluta
commented
Jan 15, 2024
Collaborator
Will try to have a look this week. |
btian1
commented
Jan 19, 2024
ContributorAuthor
Any progress? @dbaluta , this DRAFT patch try to remove each module's ctx dependency for further one logging interface.
|
dbaluta
approved these changes
Jan 25, 2024
dbaluta
commented
Jan 25, 2024
Collaborator
@btian1 tested this on imx8mp. Logging works fine after your patch. |
Test patch, will check ipc3 and ipc4 logs still correct or not, if still correct, means these part can be deleted from current logging, it is a preparation for align sof logging with zephyr logging. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
lgirdwood
approved these changes
Feb 23, 2024
lgirdwood
commented
Feb 23, 2024
Member
@btian1 draft ? |
dbaluta
commented
Feb 23, 2024
Collaborator
If i remember correctly this is only for testing purposes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.