Uh oh!
There was an error while loading. Please reload this page.
[TEST] SMP restore - #8823
Closed
lyakh wants to merge 4 commits into
Closed
Conversation
This changes the secondary core power up routine to use the newly introduced k_smp_cpu_start() and k_smp_cpu_resume(). This removes the need to mirror part of the SMP start up code from Zephyr, and no longer need to call into Zephyr private kernel code. West update includes : eefaeee061c8 kernel: smp: introduce k_smp_cpu_resume 042cb6ac4e00 soc: intel_adsp: enable DfTTS-based time stamping on ACE platforms 6a0b1da158a4 soc: intel_adsp: call framework callback function for restore e7217925c93e ace: use a 'switch' statement in pm_state_set() c99a604bbf2c ace: remove superfluous variable initialisation a0ac2faf9bde intel_adsp: ace: enable power domain 4204ca9bcb3f ace: fix DSP panic during startup (fixes c3a6274bf5e4) d4b0273ab0c4 cmake: sparse.template: add COMMAND_ERROR_IS_FATAL ca12fd13c6d3 xtensa: intel_adsp: fix a cache handling error 0ee1e28a2f5f xtensa: polish doxygen and add to missing doc 035c8d8ceb4b xtensa: remove sys_define_gpr_with_alias() a64eec6aaeec xtensa: remove XTENSA_ERR_NORET Signed-off-by: Daniel Leung <daniel.leung@intel.com> Signed-off-by: Rander Wang <rander.wang@intel.com>
zephyrproject-rtos/zephyr#68366 fixes an SOF use case when a pipeline, using a secondary core is stopped, the secondary core is powered down, but the DSP stays powered on, after which the same secondary core is powered on again. The bug prevents correct context restoration. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Starting with Zephyr commit e021ccfc745221c6 ("drivers: dma:
intel-adsp-hda: add delay to stop host dma"), the pause-resume
sof-test cases started failing on Intel cAVS2.5 platforms.
Add a delay loop around DMA stop code in chain DMA to workaround
the issue while a proper fix is under investigation. This allows
to resume integration of newer Zephyr versions to SOF and ensure
we detect any new regressions in time.
Link: thesofproject#8792
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>marc-hb
commented
Jan 31, 2024
Collaborator
CAVS NOCODEC configurations fails most tests in https://sof-ci.01.org/sofpr/PR8823/build2486/devicetest/index.html with an IPC timeout. Same in ACE NOCODEC https://sof-ci.01.org/sofpr/PR8823/build2485/devicetest/index.html Nothing in mtrace unfortunately: silent crash. "CODEC" configurations are passing besides the usual suspend/resume failures. |
marc-hb
reviewed
Jan 31, 2024
| - name: zephyr | ||
| repo-path: zephyr | ||
| revision: 9852e8e15bc8536aa1a49cc2697c1e8f802e331f | ||
| revision: pull/68366/head |
Collaborator
There was a problem hiding this comment.
This was referenced Jan 31, 2024
Merged
marc-hb
commented
Feb 1, 2024
Collaborator
Similarly bad NOCODEC results in variant #8824 |
lyakh
commented
Feb 1, 2024
CollaboratorAuthor
interesting. Comparing CI results to #8804: not very clear. The MTL failure there https://sof-ci.01.org/sofpr/PR8804/build2377/devicetest/index.html is similar to this PR's https://sof-ci.01.org/sofpr/PR8823/build2511/devicetest/index.html but their TGL failure https://sof-ci.01.org/sofpr/PR8804/build2378/devicetest/index.html is gone in our https://sof-ci.01.org/sofpr/PR8823/build2512/devicetest/index.html |
Resuming secondary cores doesn't need a callback, remove it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test zephyrproject-rtos/zephyr#68366