Uh oh!
There was an error while loading. Please reload this page.
klocwork: fix initialization of HiFi3 variables - #89
Merged
Conversation
Initializes HiFi3 variables to 0. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
mmaka1
commented
Jul 12, 2018
Author
Replacing #83 w/o merge commits. |
plbossart
left a comment
Member
There was a problem hiding this comment.
some of these inits look like false-alarms to me. No objection for now but we should really test if this is necessary when Seppo is back.
mmaka1
commented
Jul 13, 2018
Author
There are things that seem to be false positive indeed. We learned that KW is sometimes lost with Hifi3 instructions (does not understand load+increment pointer instructions, complaining about infinite loops for example). We mark such things appropriately however we usually do not try to challenge warnings about missing declaration+initialization. |
plbossart
approved these changes
Jul 13, 2018
plbossart
left a comment
Member
There was a problem hiding this comment.
tested on APL/Up2, no impact seen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initializes HiFi3 variables to 0.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com