Uh oh!
There was an error while loading. Please reload this page.
component: module_adapter: Move module_interface pointer to comp_driver - #8905
Merged
Conversation
softwarecki
requested review from
abonislawski, jxstelter, kfrydryx, kv2019i, lgirdwood, lyakh, marc-hb, marcinszkudlinski and pjdobrowolskiMarch 5, 2024 16:17
softwarecki
requested review from
dbaluta, lbetlej, mmaka1, plbossart and ranj063
as code ownersMarch 5, 2024 16:17
lyakh
reviewed
Mar 6, 2024
Uh oh!
There was an error while loading. Please reload this page.
lgirdwood
left a comment
Member
There was a problem hiding this comment.
LGTM, just one open to resolve IIUC.
lyakh
reviewed
Mar 11, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
softwareckiforce-pushed
the
module_adapter
branch
from
March 11, 2024 11:21
ec96775 to
cf88f43Comparepjdobrowolski
approved these changes
Mar 11, 2024
jxstelter
approved these changes
Mar 11, 2024
softwareckiforce-pushed
the
module_adapter
branch
from
March 11, 2024 11:50
cf88f43 to
4db4d6eComparemarcinszkudlinski
approved these changes
Mar 11, 2024
softwareckiforce-pushed
the
module_adapter
branch
2 times, most recently
from
March 11, 2024 15:44
14232c1 to
237f6a9Compare4 tasks
kv2019i
commented
Mar 13, 2024
Collaborator
@softwarecki needs a rebase |
softwareckiforce-pushed
the
module_adapter
branch
from
March 13, 2024 13:34
237f6a9 to
aecb8c4Comparelyakh
reviewed
Mar 14, 2024
Uh oh!
There was an error while loading. Please reload this page.
Moved pointer to module_interface from struct module_data to comp_driver structure. The change is aimed at clearing the module_data structure of fields intended for exclusive use by sof. All modules are eventually use module interface so this pointer will be in comp_driver anyway. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
The declare_dynamic_module_adapter function has been moved from module_adapter/module/modules.h to lib_manager and renamed to lib_manager_prepare_module_adapter. It was and still is only used in lib_manager. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwareckiforce-pushed
the
module_adapter
branch
from
March 14, 2024 17:04
aecb8c4 to
a70c2b8Comparelyakh
approved these changes
Mar 15, 2024
kv2019i
commented
Mar 18, 2024
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved pointer to module_interface from struct module_data to comp_driver structure. The change is aimed at clearing the module_data structure of fields intended for exclusive use by sof. All modules are eventually use module interface so this pointer will be in comp_driver anyway.