Uh oh!
There was an error while loading. Please reload this page.
[RFC] fix for 9343 Failed "assert(buffer->is_shared)" in fuzzing - #9356
Merged
Conversation
For cache alignment, PLATFORM_DCACHE_ALIGN is a better macro than DCACHE_LINE_SIZE (for some compilations not even defined) For CONFIG_INCOHERENT=0 compilation, it does not make any sense to call writeback/invalidate operations Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
there's no point with cache writeback/invalidate for coherent architectures. Also the buffer may be set as "shared" at any moment, not only at creation time Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
marcinszkudlinski
marked this pull request as ready for review
August 9, 2024 10:42
marcinszkudlinski
requested review from
bardliao, dbaluta, kv2019i, lbetlej, lgirdwood, mmaka1, pblaszko and plbossart
as code ownersAugust 9, 2024 10:42
lgirdwood
approved these changes
Aug 9, 2024
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Btw, I think we have minimal users of coherent.h now as transition away is almost complete. We should be able to delete coherent.h at some point.
tmleman
approved these changes
Aug 9, 2024
tmleman
left a comment
Contributor
There was a problem hiding this comment.
I wasn't able to reproduce this issue in my local environment.
kv2019i
commented
Aug 14, 2024
Collaborator
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.