Uh oh!
There was an error while loading. Please reload this page.
Add $SOF_CC_BASE variable for building XTOS with clang-based, Cadence toolchains - #9358
Merged
Conversation
We can't have a shebang and of course all variables are unused. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
"COMPILER" is a very common name with a high risk of collision. Don't use it for a minor, local variable. This also reduces confusion. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
If the user requested the Cadence toolchain by defining $XTENSA_TOOLS_ROOT, then do not "correct" the user and fallback on gcc when that variable is wrong. Fail and point at the problem instead. No one ever pays attention to build logs; as shown by new warnings being submitted on a regular basis. This also removes the local variable "XCC", the name of which was collision-prone and confusingly capitalized. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
August 10, 2024 00:47
marc-hb
requested review from
dbaluta, kv2019i, lbetlej, lgirdwood, mmaka1 and plbossart
as code ownersAugust 10, 2024 00:47
marc-hb
commented
Aug 10, 2024
CollaboratorAuthor
There is a synchronization outage following some VM migration (internal issue DIO 18204) but I checked the test results on the internal site and they are all fine, just the known LNL failures and that's it. |
This is required to allow building XTOS with newer, clang-based, Cadence toolchains as just submitted for ACP_7_0 in thesofproject#9351 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
It was awkward to depend on ZEPHYR_TOOLCHAIN_VARIANT when the testbench has absolutely nothing to do with it. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
CollaboratorAuthor
@lrudyX , @wszypelt there was some network problem in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9358/build14153658 for "Copy build to DUT?DUT_CONFIG=LNL)" The LNL build was fine so that failure was not related to this PR: |
saisurya-ch
self-requested a review
August 12, 2024 07:45
wszypelt
commented
Aug 12, 2024
@marc-hb Unfortunately, there was an error with the LNL machine, the tests are being repeated now |
marc-hb
commented
Aug 12, 2024
CollaboratorAuthor
https://sof-ci.01.org/sof-pr-viewer/#/build/PR9358/build14154731 is green now, thanks @wszypelt ! |
saisurya-ch
approved these changes
Aug 13, 2024
Member
There was a problem hiding this comment.
works fine with all compilers for AMD platforms.
Thanks @marc-hb
kv2019i
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As required by ACP_7_0 addition submitted in #9351
Other related cleanups, see commit messages.
Switch rebuild-testbench.sh to new variable.