Skip to content

iadk: Define pass buffer size and return error code from entry point function - #9424

Merged
kv2019i merged 2 commits into
thesofproject:mainfrom
softwarecki:iadk-handle
Sep 18, 2024
Merged

iadk: Define pass buffer size and return error code from entry point function#9424
kv2019i merged 2 commits into
thesofproject:mainfrom
softwarecki:iadk-handle

Conversation

@softwarecki

@softwareckisoftwarecki commented Aug 30, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

Add a definition specifying the size of space reserved in module memory for module handle and a iadk adapter.

Add a brief description of the iadk module loading sequence.

Change the definition of the system_agent_start function so that it returns the error code returned by the module's entry point functions. Return the created IadkModuleAdapter object via a parameter.

lyakh
lyakh reviewed Sep 2, 2024
View reviewed changes
Comment threadsrc/include/module/module/api_ver.h Outdated
Comment threadsrc/include/sof/audio/module_adapter/iadk/system_agent.h Outdated
Comment threadsrc/include/sof/audio/module_adapter/iadk/system_agent.h Outdated
lgirdwood
lgirdwood reviewed Sep 2, 2024
View reviewed changes

@lgirdwoodlgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to add the new macro to the IADK namespace

Comment threadsrc/include/module/module/api_ver.h Outdated
@softwarecki
softwareckiforce-pushed the iadk-handle branch 2 times, most recently from f74c888 to c288670CompareSeptember 10, 2024 15:35
kv2019i
kv2019i reviewed Sep 12, 2024
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @softwarecki , especially the module load description is a nice addition!

One question, can you check.

Comment threadsrc/audio/module_adapter/iadk/system_agent.cpp
lyakh
lyakh reviewed Sep 12, 2024
View reviewed changes
Comment threadsrc/include/module/module/api_ver.h Outdated
Comment threadsrc/audio/module_adapter/iadk/system_agent.cpp
@softwarecki
iadk: Add module pass buffer definition
c3abe51
Add a definition specifying the size of space reserved in module memory for
module handle and a iadk adapter.
Add a brief description of the iadk module loading sequence.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
@softwarecki
iadk: system_agent: Check error code returned by the module entry point
fab7cab
Change the definition of the system_agent_start function so that it returns
the error code returned by the module's entry point functions. Return the
created IadkModuleAdapter object via a parameter.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
lyakh
lyakh reviewed Sep 16, 2024
View reviewed changes
Comment threadsrc/include/sof/audio/module_adapter/iadk/api_version.h
Comment threadsrc/audio/module_adapter/iadk/system_agent.cpp
@kv2019i
kv2019i merged commit 15062f0 into thesofproject:mainSep 18, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakhlyakhlyakh left review comments
@kv2019ikv2019ikv2019i left review comments
@lgirdwoodlgirdwoodlgirdwood approved these changes
@tobonextobonextobonex approved these changes
@tmlemantmlemantmleman approved these changes
@serhiy-katsyuba-intelserhiy-katsyuba-intelserhiy-katsyuba-intel approved these changes
@abonislawskiabonislawskiAwaiting requested review from abonislawski
@marcinszkudlinskimarcinszkudlinskiAwaiting requested review from marcinszkudlinski
@jxstelterjxstelterAwaiting requested review from jxstelter
@gbernatxintelgbernatxintelAwaiting requested review from gbernatxintel
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@softwarecki@lyakh@lgirdwood@tobonex@kv2019i@tmleman@serhiy-katsyuba-intel