Uh oh!
There was an error while loading. Please reload this page.
Tools: Testbench: Convert file component to module adapter - #9432
Conversation
singalsu
commented
Sep 3, 2024
I've split out this from testbench IPC4 draft PR to ease review of large PR. I'll address the comments for file here. |
| file_uuid->d[4] = 0x08; | ||
| file_uuid->d[5] = 0xa6; | ||
| file_uuid->d[6] = 0x98; | ||
| file_uuid->d[7] = 0xc2; |
There was a problem hiding this comment.
This was commented by Liam in #9025, is there a nicer way to set this with a macro?
There was a problem hiding this comment.
define a static const UUID and memcpy() it?
There was a problem hiding this comment.
Yep, that works, thanks!
kv2019i
left a comment
There was a problem hiding this comment.
Look ok to me, one comment inline
| return -EBADMSG; | ||
| case SOF_COMP_FILEREAD: | ||
| case SOF_COMP_FILEWRITE: | ||
| config->file.channels = file->channels; |
There was a problem hiding this comment.
I think you need to keep the check on L218-219 (added recently).
There was a problem hiding this comment.
Oops yes, missed this in rebase.
b08ee3d to
32fc81fCompareThis is done as preparation for testbench IPC4 support. The update to IPC4 is simpler for a module adapter component. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
32fc81f to
ce9474cComparesingalsu
commented
Sep 12, 2024
There's a build fail in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9432/build14219918, trying again. |
singalsu
commented
Sep 12, 2024
SOFCI TEST |
lgirdwood
commented
Sep 12, 2024
singalsu
commented
Sep 17, 2024
The Jenkins failures sof-ci/jenkins/pr-device-test/main-ace and sof-ci/jenkins/pr-device-test/main-lnl are not related. The Internal Intel CI System/merge/build that previously failed is now passed. |
This is done as preparation for testbench IPC4 support. The update to IPC4 is simpler for a module adapter component.