Skip to content

LLEXT: automatically calculate module addresses (first part of #9430) - #9439

Merged
kv2019i merged 3 commits into
thesofproject:mainfrom
lyakh:test3
Sep 10, 2024
Merged

LLEXT: automatically calculate module addresses (first part of #9430)#9439
kv2019i merged 3 commits into
thesofproject:mainfrom
lyakh:test3

Conversation

@lyakh

@lyakhlyakh commented Sep 4, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

The important change here is an automatic module address calculation, simplifies modularisation a lot.

@lyakh

lyakh commented Sep 5, 2024

Copy link
Copy Markdown
CollaboratorAuthor

CI: IIUC https://sof-ci.01.org/sofpr/PR9439/build7624/devicetest/index.html unrelated, https://sof-ci.01.org/sofpr/PR9439/build7626/devicetest/index.html - one device missing

@lyakh
lyakh marked this pull request as ready for review September 5, 2024 08:58
@lyakhlyakh changed the title [DNM] Test a part of #9430Test a part of #9430Sep 5, 2024
@lyakh

lyakh commented Sep 5, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Since we decided to split #9430 and since this passes tests, let's merge it

@lyakhlyakh changed the title Test a part of #9430First part of #9430Sep 5, 2024
@lyakhlyakh changed the title First part of #9430LLEXT: automatically calculate module addresses (first part of #9430)Sep 5, 2024
@lgirdwood

lgirdwood commented Sep 9, 2024

Copy link
Copy Markdown
Member

@lyakh can you give it a quick fixup for the conflict. Thanks

@lyakh
llext: add a convenience Kconfig option to build LLEXT modules
637e07c
Add a Kconfig option that can be used to flip all LLEXT-supporting
code to a modular build. Use that global flag for smart-amp-test,
mixin-mixout and eq-iir.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
llext: automatically calculate module addresses
c580189
Currently LLEXT module starting addresses are hard-coded in their
respective CMakeLists.txt files. This is very wasteful, since it's
unknown in what order modules are loaded, inflexible and not easily
extendible to other platforms. Switch to calculating addresses
automatically based on a single per-platform Kconfig value.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
llext: add missing modules to LNL overlay
9e62eee
LNL modules overlay is missing eq_iir and mixin_mixout entries, add
them there.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh

lyakh commented Sep 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

pr-build seems stuck, restarting

@lyakh

lyakh commented Sep 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

SOFCI TEST

@lyakh

lyakh commented Sep 9, 2024

Copy link
Copy Markdown
CollaboratorAuthor

CI: unrelated LNL failures https://sof-ci.01.org/sofpr/PR9439/build7780/devicetest/index.html

@kv2019i
kv2019i merged commit 8c75f80 into thesofproject:mainSep 10, 2024
@lyakh
lyakh deleted the test3 branch September 10, 2024 06:24
@abonislawski

abonislawski commented Sep 11, 2024

Copy link
Copy Markdown
Member

Are we now unable to set module address to IMR for one module and HPSRAM for another?

@lyakh

lyakh commented Sep 11, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Are we now unable to set module address to IMR for one module and HPSRAM for another?

@abonislawski with this - no, with this module addresses are calculated automatically. Running in IMR needs to be added separately

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@iuliana-prodaniuliana-prodanAwaiting requested review from iuliana-prodaniuliana-prodan is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@abonislawskiabonislawskiAwaiting requested review from abonislawskiabonislawski is a code owner
@singalsusingalsuAwaiting requested review from singalsusingalsu is a code owner
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyakh@lgirdwood@abonislawski@kv2019i