Skip to content

Add support for byte controls in the SOF plugin - #9484

Merged
lgirdwood merged 6 commits into
thesofproject:mainfrom
ranj063:fix/plugin_kcontrol
Sep 19, 2024
Merged

Add support for byte controls in the SOF plugin#9484
lgirdwood merged 6 commits into
thesofproject:mainfrom
ranj063:fix/plugin_kcontrol

Conversation

@ranj063

@ranj063ranj063 commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

singalsu
singalsu reviewed Sep 18, 2024
View reviewed changes
Comment threadtools/ctl/ctl.c Outdated
Comment threadtools/ctl/ctl.c
lyakh
lyakh reviewed Sep 18, 2024
View reviewed changes
Comment threadtools/plugin/alsaplug/tplg.c
@ranj063
tools: ctl: Add ABI header for kcontrol read
c0fb700
This is necessary to pass the param ID for the data being requested.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
tools: plugin: tplg_ctl: Set control type
f0334b6
Set the type while parsing the controls.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
tool: plugin: tplg: Parse kcontrols for process type widgets
1008ec0
Parse and set up the kcontrols during topology parsing.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
tools: plugin: Move plug_mq_cmd_tx_rx() definition to common code
248c517
It will be used by both the PCM and the control plugin.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
tools: plugin: common: Move plug_ctl_ipc_message() definition to comm…
03715b2
…on code
It will be used by both the PCM and the control plugin.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
tools: plugin: ctl: Add support for bytes control
d5ea317
Add a new field in struct plug_shm_ctl to save the bytes data from
topology for bytes controls. This will be used to send the kcontrol data
to the modules right after they are instantiated. Fix the tlv callback
in the control to handle the tlv bytes read/write when using sof-ctl.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@lgirdwood
lgirdwood merged commit 88cde10 into thesofproject:mainSep 19, 2024
@ranj063
ranj063 deleted the fix/plugin_kcontrol branch September 19, 2024 21:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@singalsusingalsusingalsu approved these changes
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@lyakhlyakhAwaiting requested review from lyakh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ranj063@lyakh@lgirdwood@singalsu