Skip to content

ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY - #9516

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
ranj063:fix/plugin_kcontrol
Oct 2, 2024
Merged

ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY#9516
kv2019i merged 1 commit into
thesofproject:mainfrom
ranj063:fix/plugin_kcontrol

Conversation

@ranj063

@ranj063ranj063 commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Always append the UUID to the end of the module init IPC data and use that to look up the component driver instead of using the hardcoded UUID map. This will make it easier to support new processing elements with the plugin/testbench.

singalsu
singalsu reviewed Sep 26, 2024
View reviewed changes
Comment threadsrc/ipc/ipc4/helper.c
lyakh
lyakh reviewed Sep 26, 2024
View reviewed changes
Comment threadtools/plugin/alsaplug/tplg.c
Comment threadtools/plugin/alsaplug/tplg.c
singalsu
singalsu reviewed Sep 26, 2024
View reviewed changes

@singalsusingalsu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

lgirdwood
lgirdwood approved these changes Sep 26, 2024
View reviewed changes
Comment threadtools/plugin/alsaplug/tplg.c
@ranj063

ranj063 commented Sep 27, 2024

Copy link
Copy Markdown
CollaboratorAuthor

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

@singalsu I have updated the patched to also use the already set drv's for the registered components. Could you please check if that helps in your case?

@singalsu

singalsu commented Sep 27, 2024

Copy link
Copy Markdown
Collaborator

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

@singalsu I have updated the patched to also use the already set drv's for the registered components. Could you please check if that helps in your case?

Yes, everything works now with this version. Thanks a lot!

@singalsu
singalsu requested a review from lyakhSeptember 27, 2024 09:14
@singalsu

singalsu commented Sep 27, 2024

Copy link
Copy Markdown
Collaborator

The cmocka and testbench fails happen also with git main, it's not due to this PR. My own run of those tests with this patch and earlier SOF version worked.

@kv2019i

kv2019i commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

I guess cmocka tests fail due to #9518 ..? Otherwise looks good to go.

cujomalainey
cujomalainey approved these changes Sep 30, 2024
View reviewed changes

@cujomalaineycujomalainey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge upgrade! Thank you!

@lgirdwood

lgirdwood commented Oct 1, 2024

Copy link
Copy Markdown
Member

@ranj063 some conflicts, testbench ipc4 just merged.

@ranj063
ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY
2658a35
Always append the UUID to the end of the module init IPC data and use
that to look up the component driver instead of using the hardcoded UUID
map. This will make it easier to support new processing elements with
the plugin/testbench. Also, modify the get/set_large_config handlers to
use the component driver set in the dev instead of looking it up again.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
ranj063force-pushed the fix/plugin_kcontrol branch from b21fd99 to 2658a35CompareOctober 2, 2024 03:11
@ranj063

ranj063 commented Oct 2, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@ranj063 some conflicts, testbench ipc4 just merged.

rebased now @lgirdwood

@kv2019i
kv2019i merged commit addc349 into thesofproject:mainOct 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@singalsusingalsusingalsu approved these changes
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@kv2019ikv2019iAwaiting requested review from kv2019ikv2019i is a code owner
@lyakhlyakhAwaiting requested review from lyakh
+1 more reviewer
@cujomalaineycujomalaineycujomalainey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ranj063@singalsu@kv2019i@lgirdwood@lyakh@cujomalainey