Uh oh!
There was an error while loading. Please reload this page.
Enable Copier Gain feature for DMIC interface - #9537
Conversation
Define common IPC4 Dmic blob structures Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, but can you also explain when/how DMA control IPC is used. Thanks
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
60f3a5d to
9babc61Compare| dai.out_fmt = &copier->out_fmt; | ||
| #if CONFIG_COPIER_GAIN | ||
| dai.apply_gain = true; | ||
| #endif |
There was a problem hiding this comment.
What happens when no configuration is passed from the host (like in case of Linux driver)? Unity gain applied? This seems to be enabled by default.
There was a problem hiding this comment.
@kv2019i Yes, unity gain applied (gain = 1)
Uh oh!
There was an error while loading. Please reload this page.
Enable gain for DMIC interface. Configure gain feature with parameters received in DMIC BLOB. Add support for runtime DMIC gain parameters update using DMA Control IPC. Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
9babc61 to
0fd9030Compare
singalsu
left a comment
There was a problem hiding this comment.
Looks OK to me. The dmic structs are same though here more detailed based on updated documentation vs. the other dmic.h. It could be cleaned up later to avoid duplication.
Apply Copier Gain feature, introduced in #9323, to DMIC interface.
Add complete DMIC configuration blob definitions.
Use DMA Control IPC message to update gain coefficients in runtime.