Uh oh!
There was an error while loading. Please reload this page.
zephyr: lib/cpu.h: remove dependency to platform layer - #9648
Merged
Conversation
Remove dependency to platform cpu.h layer for Zephyr targets. The lib/cpu.h is now common to all SOF targets when building for Zephyr. Add a note to PLATFORM_PRIMARY_CORE_ID documentation that "primary core" is a SOF/application convention and not visible in Zephyr OS interfaces. Core 0 is the boot core in Zephyr, so use this definition as PLATFORM_PRIMARY_CORE_ID for all SOF targets. This was already the case in all platform definitions, so no functional change. In SOF, the primary/secondary distinction is primarily used in IPC code, together with Zephyr CONFIG_SMP_BOOT_DELAY=y. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
cpu.h definition is no longer needed in platform definitions for SOF Zephyr builds. Remove for all Intel targets. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Platform cpu.h no longer needed in Zephyr builds, so remove these files as obsolete. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
abonislawski, dbaluta, iuliana-prodan, lbetlej, lgirdwood, lyakh, mmaka1 and plbossart
as code ownersNovember 12, 2024 09:52
kv2019i
commented
Nov 12, 2024
CollaboratorAuthor
@thesofproject/nxp I left imx8 family out still from this PR as #9608 is open still. |
26 tasks
LaurentiuM1234
approved these changes
Nov 12, 2024
lgirdwood
approved these changes
Nov 12, 2024
lyakh
approved these changes
Nov 13, 2024
tmleman
approved these changes
Nov 13, 2024
kv2019i
commented
Nov 13, 2024
CollaboratorAuthor
sof-docs fail and Intel LNL fails all known and tracked in https://github.com/thesofproject/sof/issues?q=is%3Aissue+is%3Aopen+label%3ACI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b7598de platform: imx93_a55/imx95: remove lib/cpu.h
634bd11 platform: Intel: remove lib/cpu.h
198c718 zephyr: lib/cpu.h: remove dependency to platform layer
Link: #5794