Skip to content

platform: posix: dma: place api in iterable section - #9710

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
jilaypandya:refactor/linker-dma
Dec 10, 2024
Merged

platform: posix: dma: place api in iterable section#9710
kv2019i merged 1 commit into
thesofproject:mainfrom
jilaypandya:refactor/linker-dma

Conversation

@jilaypandya

@jilaypandyajilaypandya commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

this commit refactors dma_driver_api in iterable_section

@sofci

sofci commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@jilaypandyajilaypandya mentioned this pull request Dec 4, 2024
Closed
kv2019i
kv2019i approved these changes Dec 4, 2024
View reviewed changes

@kv2019ikv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jilaypandya ! Let's have the CI test this out as well.

@jilaypandya

jilaypandya commented Dec 4, 2024

Copy link
Copy Markdown
ContributorAuthor

I think I would need some help to get CI done correctly.

@kv2019i

kv2019i commented Dec 5, 2024

Copy link
Copy Markdown
Collaborator

@jilaypandya I know what's the problem, SOF doesn't have "device: Add DEVICE_API macros" yet. We are struggling with a series of regressions that has blocked our Zephyr updates, so we are stuck at e59289d89999 for Zephyr. But this should be solved soon, I had almost clean CI with #9705 ... still need one more fix on Zephyr side before we can upgrade (and then your PR should pass SOF CI).

@lyakh

lyakh commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

test this please

@kv2019i

kv2019i commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

@jilaypandya Can you rebase now? #9712 merged to SOF, so Zephyr should be new enough for this PR to pass CI tests.

@jilaypandya
platform: posix: dma: place api in iterable section
0e023de
this commit refactors dma_driver_api in iterable_section
Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
@jilaypandya

jilaypandya commented Dec 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@jilaypandya Can you rebase now? #9712 merged to SOF, so Zephyr should be new enough for this PR to pass CI tests.

Done

@kv2019i

kv2019i commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@kv2019i

kv2019i commented Dec 10, 2024

Copy link
Copy Markdown
Collaborator

Thank you @jilaypandya , all mandatory now passing, proceeding with merge.

@kv2019i
kv2019i merged commit 15f68ec into thesofproject:mainDec 10, 2024
@jilaypandya
jilaypandya deleted the refactor/linker-dma branch December 17, 2024 12:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@plbossartplbossartAwaiting requested review from plbossartplbossart is a code owner
@mmaka1mmaka1Awaiting requested review from mmaka1mmaka1 is a code owner
@lbetlejlbetlejAwaiting requested review from lbetlejlbetlej is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jilaypandya@sofci@kv2019i@lyakh@lgirdwood