Skip to content

DRAM: fast_get() cache-handling improvements - #9817

Merged
kv2019i merged 3 commits into
thesofproject:mainfrom
lyakh:dram
Feb 11, 2025
Merged

DRAM: fast_get() cache-handling improvements#9817
kv2019i merged 3 commits into
thesofproject:mainfrom
lyakh:dram

Conversation

@lyakh

@lyakhlyakh commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

Use uncached aliases for potentially shared objects, synchronise cache properly when sharing cached access

@lyakh
fast_get: invalidate cache of shared data
ad2f0e5
When multiple users access the same DRAM data via the fast_get() API,
they can run on different cores. The data is immutable, but when
initially pointing to it, cache has to be invalidated.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
fast_get: entries must be uncached
4b30fad
fast_get entry list is global, it can be accessed from any core,
allocate it uncached.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
fast_get: (cosmetic) reduce the number of gotos
7746ded
Invert a condition to eliminate a single goto.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
lyakh requested a review from jsarhaFebruary 7, 2025 09:20
@lyakhlyakh mentioned this pull request Feb 7, 2025
Merged
@lyakh

lyakh commented Feb 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

SOFCI TEST

@lyakh

lyakh commented Feb 11, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

CI: 1 alsabat failure on HDA MTL https://sof-ci.01.org/sofpr/PR9817/build10578/devicetest/index.html?model=MTLP_RVP_HDA&testcase=check-alsabat-headset-capture-997, TGL nocodec not tested, but the LNL failure puzzles me... https://sof-ci.01.org/sofpr/PR9817/build10577/devicetest/index.html but it absolutely cannot be caused by this PR. This PR changes behaviour of fast_get() and fast_put() functions only and these functions so far are only used by the SRC component, which is only used during audio streaming, so there's no way it can lead to module loading failing. I'll re-run jenkins

@lyakh

lyakh commented Feb 11, 2025

Copy link
Copy Markdown
CollaboratorAuthor

SOFCI TEST

@lyakh

lyakh commented Feb 11, 2025

Copy link
Copy Markdown
CollaboratorAuthor

CI: now ACE (MTL), cAVE and LNL are all green (except for a single untested system in each), and PTL is just not fully configured yet in CI

@kv2019i
kv2019i merged commit b7f3871 into thesofproject:mainFeb 11, 2025
@lyakh
lyakh deleted the dram branch February 11, 2025 11:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwoodlgirdwoodlgirdwood approved these changes
@kv2019ikv2019ikv2019i approved these changes
@iuliana-prodaniuliana-prodanAwaiting requested review from iuliana-prodaniuliana-prodan is a code owner
@dbalutadbalutaAwaiting requested review from dbalutadbaluta is a code owner
@abonislawskiabonislawskiAwaiting requested review from abonislawskiabonislawski is a code owner
@jsarhajsarhaAwaiting requested review from jsarha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lyakh@lgirdwood@kv2019i