Uh oh!
There was an error while loading. Please reload this page.
llext: use the new inspection API - #9823
Closed
pillo79 wants to merge 4 commits into
Closed
Conversation
sofci
commented
Feb 10, 2025
Collaborator
Can one of the admins verify this patch?
|
lgirdwood
commented
Feb 10, 2025
Member
test this please |
pillo79force-pushed
the
pr-llext-inspect-api
branch
2 times, most recently
from
February 11, 2025 09:04
a579f71 to
e36aac2Comparejsarha
reviewed
Feb 11, 2025
jsarha
left a comment
Contributor
There was a problem hiding this comment.
Couple of issues i found while trying to understand what this (and the llext code in general) does (which is still on going).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pillo79force-pushed
the
pr-llext-inspect-api
branch
from
February 11, 2025 09:37
e36aac2 to
e99d9d5Comparelyakh
commented
Feb 11, 2025
Collaborator
SOFCI TEST |
lyakh
reviewed
Feb 11, 2025
Uh oh!
There was an error while loading. Please reload this page.
pillo79force-pushed
the
pr-llext-inspect-api
branch
from
February 11, 2025 14:58
e99d9d5 to
a75cf84CompareThis is a temporary change to use the Zephyr PR adding the new LLEXT inspection API. This is needed to test the SOF integration with the new API. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
This commit does some minor preparatory refactors in the llext_manager module in preparation for the upcoming change to use the new LLEXT inspection API. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
pillo79force-pushed
the
pr-llext-inspect-api
branch
from
February 11, 2025 16:48
1c0910c to
0ab0537CompareThis patch converts the llext_manager to use the new LLEXT inspection API. The new API allows to get information about sections and regions without the need to access the internal structures of the LLEXT loader, decoupling SOF and LLEXT code and making it easier to maintain. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
pillo79force-pushed
the
pr-llext-inspect-api
branch
from
February 12, 2025 08:03
0ab0537 to
99611bcComparelyakh
commented
Feb 12, 2025
Collaborator
SOFCI TEST |
lgirdwood
commented
Feb 12, 2025
Member
@pillo79 I've added you to sof-developers so new PRs will automatically run in CI. |
Add debugging code for comparing memory copy operations between previous and current situations. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
pillo79force-pushed
the
pr-llext-inspect-api
branch
from
February 12, 2025 13:10
99611bc to
4987f62Comparelyakh
commented
Feb 12, 2025
Collaborator
SOFCI TEST |
ContributorAuthor
Closed in favor of #9831 to take advantage of the new SOF developer status and run CI automatically (thanks so much! 😍). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to improve SOF by minimizing its dependency on LLEXT internals.
Instead of relying on direct field access, the code in
llext_manager.cis refactored to use a set of new, stable LLEXT APIs that expose the same information. These code changes should have no measurable effects in the rest of SOF.Note
mainare expected.