comp: Add initial support for NXP Essential Audio Processing component by dbaluta · Pull Request #9999 · thesofproject/sof

dbaluta · 2025-05-12T07:03:35Z

comp: Add initial NXP Essential Audio Processing component
NXP’s Essential Audio Processing (EAP) library is a bundle of audio
processing blocks for enhancing the tonal and spatial perception
of sound in audio applications
The initial support adds some presets parameters that can be set
using the standard alsamixer interface.
* AllEffectOff
* VoiceEnhancer
* MusicEnhancer
* AutoVolumeLeveler
* ConcertSound
* LoudnessMaximiser

Library binaries, headers and more documentation can be found here: https://github.com/nxp-mcuxpresso/EAP

Copilot

Pull Request Overview

This PR introduces initial support for the NXP Essential Audio Processing (EAP) component, adding both the full EAP processing implementation and its associated topology and configuration files.

Added new EAP processing code and parameter presets in src/audio/nxp/eap.c and related header files.
Introduced topology and module adapter updates (M4 scripts and CMake/Kconfig changes) to integrate the new EAP component.
Registered the component via uuid-registry.txt and exposed an interface in component.h.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
uuid-registry.txt	Registers the new uuid for the nxp_eap component.
tools/topology/topology1/sof/pipe-eap-playback.m4	Adds pipeline topology for EAP playback functionality.
tools/topology/topology1/m4/eap_controls.m4	Defines the control enumerations for the EAP component.
tools/topology/topology1/m4/eap.m4	Provides macros for creating EAP widget sections.
tools/topology/topology1/CMakeLists.txt	Updates topology configuration to include the new EAP pipeline.
src/include/sof/audio/nxp/eap/eap_lib_defines.h	Introduces library macros for EAP processing features.
src/include/sof/audio/nxp/eap/EAP_Parameter_presets.h	Adds preset arrays for various EAP effects.
src/include/sof/audio/component.h	Declares the new initialization function for the NXP EAP interface.
src/audio/nxp/eap_stub.c	Implements stub functions for EAP when stub support is enabled.
src/audio/nxp/eap.c	Implements the full processing functionality and configuration for EAP.
src/audio/nxp/Kconfig	Adds Kconfig entries for enabling EAP and its stub.
src/audio/nxp/CMakeLists.txt	Configures CMake to build the EAP component and optionally its stub.
src/audio/Kconfig	Sources the nxp/Kconfig for component integration.
src/audio/CMakeLists.txt	Integrates the nxp subdirectory into the overall build.

Comments suppressed due to low confidence (1)

src/include/sof/audio/nxp/eap/EAP_Parameter_presets.h:1

[nitpick] The preset parameter arrays are defined in a header file without 'static' or 'const', which may lead to multiple definition issues. Consider declaring them as 'static const' if intended for use as constant data.

#ifndef EAP_PARAMETER_PRESETS_H_

lgirdwood

@dbaluta good stuff ! I think we can land this for v2.12.
Btw, if convenient you can copy the tensorflow git clone script and adjust it for EAP to make it super easy for EAP users to get started (i.e. it can clone a known good commit).

dbaluta · 2025-05-12T09:39:49Z

@dbaluta good stuff ! I think we can land this for v2.12.
Btw, if convenient you can copy the tensorflow git clone script and adjust it for EAP to make it super easy for EAP users to get started (i.e. it can clone a known good commit).

We have only one repo for the binaries and it's handled inside our Yocto distro. But will have a look might be useful to have it inside the SOF scripts.

Thanks,

kv2019i

Looks good. Please look at the comment with freeing memory on error path. Otherwise no blocking comments. The header location is something we probably need to work on (see inline), but does not have to be made in this PR.

kv2019i · 2025-05-15T06:00:36Z

+	int index;
+	LVM_ReturnStatus_en ret;
+	struct comp_dev *dev = mod->dev;
+	struct nxp_eap_data *eap = module_get_private_data(mod);


minor nit: reverse-xmas tree order for declarations would be nice

lgirdwood · 2025-05-16T10:26:09Z

@dbaluta @kv2019i I've marked this for v2.13 as we can take it into the release if ready in next few days. Its a great feature to have.

dbaluta · 2025-05-16T12:37:54Z

Need to fix the last commit. Will do this on Monday.

NXP’s Essential Audio Processing (EAP) library is a bundle of audio processing blocks for enhancing the tonal and spatial perception of sound in audio applications The initial support adds some presets parameters that can be set using the standard alsamixer interface. * AllEffectOff * VoiceEnhancer * MusicEnhancer * AutoVolumeLeveler * ConcertSound * LoudnessMaximiser Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

This adds Essential Audio Processing (EAP) topology for i.MX8MP board with wm8960 codec. This will allow experiment with various EAP library preset parameters. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

This is used for CI testing and compiling. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

kv2019i · 2025-05-19T11:10:10Z

Waiting for the Intel Internal CI job to complete.

testbench CI will not complete, so won't wait for that (#10017) .

Otherwise ready to merge.

CopilotAI review requested due to automatic review settings May 12, 2025 07:03

dbaluta requested review from kv2019i, lbetlej, lgirdwood, mmaka1, plbossart and ranj063 as code owners May 12, 2025 07:03

dbaluta changed the title ~~comp: Add initial NXP Essential Audio Processing component~~comp: Add initial support for NXP Essential Audio Processing componentMay 12, 2025

CopilotAI reviewed May 12, 2025
View reviewed changes

Comment threadsrc/audio/nxp/eap.c Outdated
Comment threadsrc/audio/nxp/eap.c Outdated

lgirdwood reviewed May 12, 2025
View reviewed changes

lyakh requested changes May 13, 2025
View reviewed changes

kv2019i reviewed May 15, 2025
View reviewed changes

lgirdwood added this to the v2.13 milestone May 16, 2025

dbaluta force-pushed the add_eap_nxp branch from 6b0383a to 141bfedCompare May 16, 2025 12:32

dbaluta force-pushed the add_eap_nxp branch from a6b900f to 585716eCompare May 19, 2025 06:43

lyakh approved these changes May 19, 2025
View reviewed changes

dbaluta force-pushed the add_eap_nxp branch from 585716e to 1da7feeCompare May 19, 2025 08:19

dbaluta added 2 commits May 19, 2025 11:19

topology1: Add topology to support NXP EAP
58870b3
This adds Essential Audio Processing (EAP) topology for i.MX8MP board with wm8960 codec. This will allow experiment with various EAP library preset parameters. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

audio: eap: Add EAP library stub for testing
1da7fee
This is used for CI testing and compiling. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

kv2019i approved these changes May 19, 2025
View reviewed changes

dbaluta merged commit 0f87a81 into thesofproject:mainMay 19, 2025

kv2019i mentioned this pull request May 19, 2025
[stable-v2.13] backport of PRs #10020
Merged

Uh oh!

Conversation

dbaluta commented May 12, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

dbaluta commented May 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019iMay 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lgirdwood commented May 16, 2025

Uh oh!

dbaluta commented May 16, 2025

Uh oh!

kv2019i commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dbaluta commented May 12, 2025•
edited
Loading