Skip to content

Test metadata files: bump expiration date and resign - #1631

Merged
jku merged 1 commit into
theupdateframework:developfrom
MVrachev:fix-test-error
Oct 25, 2021
Merged

Test metadata files: bump expiration date and resign#1631
jku merged 1 commit into
theupdateframework:developfrom
MVrachev:fix-test-error

Conversation

@MVrachev

@MVrachevMVrachev commented Oct 23, 2021

Copy link
Copy Markdown
Collaborator

Description of the changes being introduced by the pull request:

Our newly added metadata files in the
tests/repository_data/fishy_rolenames/metadata directory have an expiry
date until "2021-10-22T11:21:56Z" and today while running the tests on
develop branch I recived this error:
ExpiredMetadataError("Metadata X expired on Fri Oct 22 11:21:56 2021")
when running the tests in tests/test_updater.py file and more precisly
the TestUpdaterRolenames.test_unusual_rolenames() test.

That's why I decided to bump the expiration date to a random time in
the future (October 22-nd 2050) and I had to resign all of the metadata
files.

Signed-off-by: Martin Vrachev mvrachev@vmware.com

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Our newly added metadata files in the
tests/repository_data/fishy_rolenames/metadata directory have an expiry
date until "2021-10-22T11:21:56Z" and today while running the tests on
develop branch I recived this error:
ExpiredMetadataError("Metadata X expired on Fri Oct 22 11:21:56 2021")
when running the tests in tests/test_updater.py file and more precisly
the TestUpdaterRolenames.test_unusual_rolenames() test.
That's why I decided to bump the expiration date to a random time in
the future (October 22-nd 2050) and I had to resign all of the metadata
files.
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1375801096

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.427%

TotalsCoverage Status
Change from base Build 1369286823:0.0%
Covered Lines:3943
Relevant Lines:4027

💛 - Coveralls

@MVrachev

Copy link
Copy Markdown
CollaboratorAuthor

The test failure I described can be seen here:
https://github.com/theupdateframework/python-tuf/runs/3984749289?check_suite_focus=true

@MVrachevMVrachev mentioned this pull request Oct 23, 2021
3 tasks
jku
jku approved these changes Oct 25, 2021

@jkujku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I produced this from RepositorySimulator (where the expiry doesn't matter as we re-generate for every test run) and failed to notice this 🤦

@jku
jku merged commit 2206fc9 into theupdateframework:developOct 25, 2021
@MVrachev
MVrachev deleted the fix-test-error branch October 27, 2021 13:55
@lukpuehlukpueh mentioned this pull request Dec 13, 2021
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1375801096

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 98.477%

TotalsCoverage Status
Change from base Build 1369286823:1.1%
Covered Lines:3782
Relevant Lines:3808

💛 - Coveralls

1 similar comment
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1375801096

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 98.477%

TotalsCoverage Status
Change from base Build 1369286823:1.1%
Covered Lines:3782
Relevant Lines:3808

💛 - Coveralls

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MVrachev@coveralls@jku