Uh oh!
There was an error while loading. Please reload this page.
Clarify key rotations test cases by using keywords - #1649
Conversation
Pull Request Test Coverage Report for Build 1448985910Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
8f95e2a to
beb8087CompareMVrachev
commented
Nov 5, 2021
jku
left a comment
There was a problem hiding this comment.
LGTM. Is black going to accept these without complaints when you enable black?
In order to make the `RootVersion` test cases understandable it's better if we use keywords and don't split the different RootVersions into multiple lines. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
MVrachev
commented
Nov 11, 2021
Ohh... I forgot to run black on that change. |
coveralls
commented
Dec 23, 2024
Pull Request Test Coverage Report for Build 1393945892Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
coveralls
commented
Dec 23, 2024
Pull Request Test Coverage Report for Build 1393945892Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Description of the changes being introduced by the pull request:
As I mentioned in my comment here #1607 (comment) while I was reviewing #1635 it was a little hard for me to remember the placement of the arguments for RootVersion considering they are 15 root rotations tested and the dataset becomes a larger piece of code.
That's why I suggest using keywords whenever possible to do that without splitting the
RootVersioninstance creation into two lines.Signed-off-by: Martin Vrachev mvrachev@vmware.com
Please verify and check that the pull request fulfills the following
requirements: