Skip to content

GH actions: limit GitHub token visibility - #1652

Merged
jku merged 1 commit into
theupdateframework:developfrom
jku:limit-github-token-visibility
Nov 17, 2021
Merged

GH actions: limit GitHub token visibility#1652
jku merged 1 commit into
theupdateframework:developfrom
jku:limit-github-token-visibility

Conversation

@jku

@jkujku commented Nov 1, 2021

Copy link
Copy Markdown
Member

Token should be visible to only the code that actually needs it.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

Token should be visible to only the code that actually needs it.
Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1406987769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.43%

TotalsCoverage Status
Change from base Build 1390970499:0.0%
Covered Lines:3946
Relevant Lines:4030

💛 - Coveralls

@kairoaraujokairoaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kairoaraujokairoaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sechkovasechkova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jku
jku merged commit 6744f6a into theupdateframework:developNov 17, 2021
@lukpuehlukpueh mentioned this pull request Dec 13, 2021
@coveralls

coveralls commented Dec 23, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1406987769

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 98.54%

TotalsCoverage Status
Change from base Build 1390970499:1.1%
Covered Lines:3116
Relevant Lines:3129

💛 - Coveralls

@jku
jku deleted the limit-github-token-visibility branch December 30, 2024 09:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jku@coveralls@kairoaraujo@sechkova