Skip to content

github: explicitly set workflow permissions - #1663

Merged
lukpueh merged 1 commit into
theupdateframework:developfrom
jku:gh-actions-set-permissions
Nov 4, 2021
Merged

github: explicitly set workflow permissions#1663
lukpueh merged 1 commit into
theupdateframework:developfrom
jku:gh-actions-set-permissions

Conversation

@jku

@jkujku commented Nov 4, 2021

Copy link
Copy Markdown
Member
  • current workflow only needs to read git content
  • if the workflow in the future does need write access (or even other read access than the git repo), it's good to
    see permissions explicitly changing

For context: "pull_request" runs never have any write access anyway, so this
significantly changes only the "push" runs that happen when branches are
merged to develop.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

Fixes#1662

* current workflow only needs to read git content
* if the workflow in the future does need write access, it's good to
see permissions explicitly changing
For context: "pull_request" runs never have write access anyway, so this
significantly changes only the "push" runs that happen when branches are
merged to develop.
Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1420674927

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.442%

TotalsCoverage Status
Change from base Build 1420270018:0.0%
Covered Lines:3946
Relevant Lines:4030

💛 - Coveralls

@jku

jku commented Nov 4, 2021

Copy link
Copy Markdown
MemberAuthor

For anyone wondering: you can see the permissions by going to the job logs, opening "Set up job", then opening "GITHUB_TOKEN Permissions"

@lukpuehlukpueh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-checked with relevant GH docs. LGTM. Thanks, Jussi!

@lukpueh
lukpueh merged commit d70c3b3 into theupdateframework:developNov 4, 2021
@lukpuehlukpueh mentioned this pull request Dec 13, 2021
@coveralls

coveralls commented Dec 23, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1420674927

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 98.548%

TotalsCoverage Status
Change from base Build 1420270018:1.1%
Covered Lines:3116
Relevant Lines:3129

💛 - Coveralls

@jku
jku deleted the gh-actions-set-permissions branch December 30, 2024 09:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github actions: set workflow permissions to read-only

3 participants

@jku@coveralls@lukpueh