Skip to content

tests: Refactor client bootstrap - #1715

Merged
sechkova merged 1 commit into
theupdateframework:developfrom
jku:tests-sim-updater-bootstrap
Dec 10, 2021
Merged

tests: Refactor client bootstrap#1715
sechkova merged 1 commit into
theupdateframework:developfrom
jku:tests-sim-updater-bootstrap

Conversation

@jku

@jkujku commented Dec 8, 2021

Copy link
Copy Markdown
Member

Setting up the client (when using RepositorySimulator) can be a bit
cleaner.

Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com


just tiny test refactor

Comment threadtests/test_updater_consistent_snapshot.py Outdated
Comment threadtests/test_updater_top_level_update.py
Comment threadtests/test_updater_top_level_update.py
Setting up the client (when using RepositorySimulator) can be a bit
cleaner.
Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
@jku
jkuforce-pushed the tests-sim-updater-bootstrap branch from 957e4a1 to b34d1b4CompareDecember 9, 2021 07:46
@jku

jku commented Dec 9, 2021

Copy link
Copy Markdown
MemberAuthor

Fixed the issues Kairo pointed out in test_updater_consistent_snapshot.py. Other files were not touched

@coveralls

coveralls commented Dec 9, 2021

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1557693271

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 98.58%

TotalsCoverage Status
Change from base Build 1554266096:1.0%
Covered Lines:3871
Relevant Lines:3897

💛 - Coveralls

@kairoaraujokairoaraujo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sechkova
sechkova merged commit bdf1cbb into theupdateframework:developDec 10, 2021
@lukpuehlukpueh mentioned this pull request Dec 13, 2021
@jku
jku deleted the tests-sim-updater-bootstrap branch December 30, 2024 09:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jku@coveralls@kairoaraujo@sechkova