Uh oh!
There was an error while loading. Please reload this page.
tests: Refactor key rotation in simulator - #1766
Merged
lukpueh merged 1 commit intoFeb 3, 2022
Merged
Conversation
Pull Request Test Coverage Report for Build 1683754305Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
kairoaraujo
left a comment
Contributor
There was a problem hiding this comment.
Very nice refactoring.
Uh oh!
There was an error while loading. Please reload this page.
Add a method to rotate roles keys into RepositorySimulator (only top-level roles are supported for now). Rotation is used in four places already and this refactoring makes the tests easier to understand. Signed-off-by: Jussi Kukkonen <jkukkonen@vmware.com>
jkuforce-pushed
the
tests-sim-add-key-rotation
branch
from
January 12, 2022 07:34
b11b3b3 to
a38bf7cComparejku
commented
Jan 12, 2022
MemberAuthor
improved variable names as Kairo suggested, no other changes |
kairoaraujo
approved these changes
Jan 12, 2022
Merged
MVrachev
approved these changes
Feb 2, 2022
MVrachev
left a comment
Collaborator
There was a problem hiding this comment.
Agree with Kairo.
Great refactoring.
lukpueh
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a method to rotate roles keys into RepositorySimulator (only
top-level roles are supported for now). Rotation is used in four
places already and this refactoring makes the tests easier to
understand.
Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com