Skip to content

Add README.md for section-report - #101

Merged
hidakatsuya merged 1 commit into
masterfrom
add-readme-of-section-report
Jul 10, 2021
Merged

Add README.md for section-report#101
hidakatsuya merged 1 commit into
masterfrom
add-readme-of-section-report

Conversation

@hidakatsuya

@hidakatsuyahidakatsuya commented Jul 7, 2021

Copy link
Copy Markdown
Member

No description provided.

@hidakatsuyahidakatsuya self-assigned this Jul 7, 2021
@hidakatsuya
hidakatsuyaforce-pushed the add-readme-of-section-report branch 3 times, most recently from 0b50f20 to ca07063CompareJuly 8, 2021 16:18
@hidakatsuya
hidakatsuya requested a review from maeda-mJuly 8, 2021 16:20
@hidakatsuya

Copy link
Copy Markdown
MemberAuthor

@maeda-m レピューお願いします。

@maeda-mmaeda-m left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hidakatsuya いつもありがとうございます。

LGTM!!

次の内容がわかる優れたREADMEだと思いました。

  • 今どういった状況なのか?
  • どうすれば使用できるのか?
  • これまでの経緯(関連リンク)

Comment threadsection-report/README.md Outdated
### Running tests

```
npm run test:units

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
npm run test:units
npm run test:unit

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! fixes and fixup are done.

@hidakatsuya
hidakatsuyaforce-pushed the add-readme-of-section-report branch from ca07063 to be03889CompareJuly 10, 2021 10:20
@hidakatsuya
hidakatsuya merged commit 1eb3d1b into masterJul 10, 2021
@hidakatsuya
hidakatsuya deleted the add-readme-of-section-report branch July 10, 2021 10:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hidakatsuya@maeda-m