Skip to content

[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SDaian merged 5 commits into from
Aug 18, 2022
Merged

[angular-ngrx-scss] - Issue pull request item #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e366a9
[angular-ngrx-scss] - Issue pull request item
SDaian Aug 1, 2022
113fbe8
Fix comments
SDaian Aug 2, 2022
c57b267
Fix format
SDaian Aug 4, 2022
13d0e55
Fix comments
SDaian Aug 16, 2022
d1ba1f7
Added isOpen flag
SDaian Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
<div class="issues-list-container">
<ng-container *ngFor="let issue of issues">
<app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
</ng-container>
</div>
</div>
3 changes: 0 additions & 3 deletions angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss
View file
Open in desktop

This file was deleted.

8 changes: 5 additions & 3 deletions angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
selector: 'app-issues-list',
templateUrl: './issues-list.component.html',
styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
@Input() issues: Issue[] = [];
}
46 changes: 46 additions & 0 deletions ...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
<div class="item-container">
<div class="info">
<ng-container *ngIf="isOpen; else closed">
<!-- no-entry -->
<span class="icon {{ item.state }}" appOcticon="no-entry"></span>
</ng-container>
<ng-template #closed>
<!-- issue-closed -->
<span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
</ng-template>
<div>
<div class="content">
<span class="title">{{ item.title }}</span>
<span class="inline" *ngFor="let label of item.labels">
<span
[style.background-color]="colorMap(label.color)"
class="label"
>
{{ label.name }}
</span>
</span>
</div>
<div class="meta">
#{{ item.number }}
<span *ngIf="isOpen">
opened
{{ item.created_at | relativeTime }}
</span>
by
<span class="created-by">{{ item.user.login }}</span>
<span *ngIf="!isOpen">
was closed
{{ item.closed_at! | relativeTime }}
</span>
</div>
</div>
</div>
<div class="comments" *ngIf="item.comments">
<span class="icon" appOcticon="comment"></span>
<span data-testid="comment count">
{{ item.comments }}
</span>
</div>
</div>
</div>
76 changes: 76 additions & 0 deletions ...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
padding: 1.125rem;
border-bottom: 1px solid variables.$gray200;

&:hover {
background-color: variables.$gray100;
}
}

.item-container {
display: flex;
justify-content: space-between;
align-items: center;

.info {
display: flex;
}

.comments {
display: flex;
flex-direction: column;
}
}

.icon {
margin-right: 0.5rem;

&.open {
color: $color-open;
}

&.closed {
color: $color-closed;
}
}

.content {
.title {
font-size: 1.125rem;
font-weight: 600;
margin-right: 0.25rem;

&:hover {
color: variables.$blue300;
}
}

.label {
font-weight: 500;
font-size: 0.875rem;
margin: 0 0.385rem;
padding: 0.125rem 0.5rem;
cursor: pointer;
border-radius: 0.875rem;
}
}

.meta {
line-height: 0.875rem;
font-size: 0.875rem;
margin-top: 0.325rem;
color: variables.$gray600;

.created-by {
cursor: pointer;

&:hover {
color: variables.$blue300;
}
}
}
20 changes: 20 additions & 0 deletions ...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
selector: 'app-repo-issue-pull-card',
templateUrl: './repo-issue-pull-card.component.html',
styleUrls: ['./repo-issue-pull-card.component.scss'],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
@Input() item?: Issue;

get isOpen(): boolean {
return this.item?.state === 'open';
}

colorMap(color: string): string {
return `#${color}`;
}
}
3 changes: 3 additions & 0 deletions angular-ngrx-scss/src/app/shared/shared.module.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
OcticonsDirective,
FilterDropdownComponent,
PaginationComponent,
RepoIssuePullCardComponent,
],
imports: [CommonModule, RouterModule],
exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
OcticonsDirective,
FilterDropdownComponent,
PaginationComponent,
RepoIssuePullCardComponent,
],
})
export class SharedModule {}
2 changes: 2 additions & 0 deletions angular-ngrx-scss/src/app/shared/styles/variables.scss
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[angular-ngrx-scss] - Issue pull request item by SDaian · Pull Request #502 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[angular-ngrx-scss] - Issue pull request item#502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

SDaian
merged 5 commits into

from

Aug 18, 2022
 Merged


[angular-ngrx-scss] - Issue pull request item
#502
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
2e366a9

[angular-ngrx-scss] - Issue pull request item


SDaian Aug 1, 2022
113fbe8

Fix comments


SDaian Aug 2, 2022
c57b267

Fix format


SDaian Aug 4, 2022
13d0e55

Fix comments


SDaian Aug 16, 2022
d1ba1f7

Added isOpen flag


SDaian Aug 17, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


8 changes: 7 additions & 1 deletion
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1 +1,7 @@
<div class="issue"><div class="issues-list-container"></div></div>
<div class="issue">
 <div class="issues-list-container">
 <ng-container *ngFor="let issue of issues">
 <app-repo-issue-pull-card [item]="issue"></app-repo-issue-pull-card>
 </ng-container>
 </div>
</div>

3 changes: 0 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.scss

View file


Open in desktop


This file was deleted.


8 changes: 5 additions & 3 deletions
angular-ngrx-scss/src/app/issues/components/issues-list/issues-list.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
import { Component } from '@angular/core';
import { Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-issues-list',
 templateUrl: './issues-list.component.html',
 styleUrls: ['./issues-list.component.scss'],
})
export class IssuesListComponent {}
export class IssuesListComponent {
 @Input() issues: Issue[] = [];
}

46 changes: 46 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.html

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
<div class="item" *ngIf="item">
 <div class="item-container">
 <div class="info">
 <ng-container *ngIf="isOpen; else closed">
 <!-- no-entry -->
 <span class="icon {{ item.state }}" appOcticon="no-entry"></span>
 </ng-container>
 <ng-template #closed>
 <!-- issue-closed -->
 <span class="icon {{ item.state }}" appOcticon="issue-closed"></span>
 </ng-template>
 <div>
 <div class="content">
 <span class="title">{{ item.title }}</span>
 <span class="inline" *ngFor="let label of item.labels">
 <span
 [style.background-color]="colorMap(label.color)"
 class="label"
 >
 {{ label.name }}
 </span>
 </span>
 </div>
 <div class="meta">
 #{{ item.number }}
 <span *ngIf="isOpen">
 opened
 {{ item.created_at | relativeTime }}
 </span>
 by
 <span class="created-by">{{ item.user.login }}</span>
 <span *ngIf="!isOpen">
 was closed
 {{ item.closed_at! | relativeTime }}
 </span>
 </div>
 </div>
 </div>
 <div class="comments" *ngIf="item.comments">
 <span class="icon" appOcticon="comment"></span>
 <span data-testid="comment count">
 {{ item.comments }}
 </span>
 </div>
 </div>
</div>

76 changes: 76 additions & 0 deletions
...x-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
@use '../../styles/variables.scss';

$color-open: variables.$green100;
$color-closed: variables.$purple100;

.item {
 padding: 1.125rem;
 border-bottom: 1px solid variables.$gray200;

 &:hover {
 background-color: variables.$gray100;
 }
}

.item-container {
 display: flex;
 justify-content: space-between;
 align-items: center;

 .info {
 display: flex;
 }

 .comments {
 display: flex;
 flex-direction: column;
 }
}

.icon {
 margin-right: 0.5rem;

 &.open {
 color: $color-open;
 }

 &.closed {
 color: $color-closed;
 }
}

.content {
 .title {
 font-size: 1.125rem;
 font-weight: 600;
 margin-right: 0.25rem;

 &:hover {
 color: variables.$blue300;
 }
 }

 .label {
 font-weight: 500;
 font-size: 0.875rem;
 margin: 0 0.385rem;
 padding: 0.125rem 0.5rem;
 cursor: pointer;
 border-radius: 0.875rem;
 }
}

.meta {
 line-height: 0.875rem;
 font-size: 0.875rem;
 margin-top: 0.325rem;
 color: variables.$gray600;

 .created-by {
 cursor: pointer;

 &:hover {
 color: variables.$blue300;
 }
 }
}

20 changes: 20 additions & 0 deletions
...grx-scss/src/app/shared/components/repo-issue-pull-card/repo-issue-pull-card.component.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { Issue } from 'src/app/repository/services/repository.interfaces';

@Component({
 selector: 'app-repo-issue-pull-card',
 templateUrl: './repo-issue-pull-card.component.html',
 styleUrls: ['./repo-issue-pull-card.component.scss'],
 changeDetection: ChangeDetectionStrategy.OnPush,
})
export class RepoIssuePullCardComponent {
 @Input() item?: Issue;

 get isOpen(): boolean {
 return this.item?.state === 'open';
 }

 colorMap(color: string): string {
 return `#${color}`;
 }
}

3 changes: 3 additions & 0 deletions
angular-ngrx-scss/src/app/shared/shared.module.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,7 @@ import { OcticonsDirective } from './directives/octicons.directive';
import { FilterDropdownComponent } from './components/filter-dropdown/filter-dropdown.component';
import { MarkdownPipe } from './pipes/markdown.pipe';
import { PaginationComponent } from './components/pagination/pagination.component';
import { RepoIssuePullCardComponent } from './components/repo-issue-pull-card/repo-issue-pull-card.component';

@NgModule({
 declarations: [
Expand All@@ -16,6 +17,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
 imports: [CommonModule, RouterModule],
 exports: [
Expand All@@ -25,6 +27,7 @@ import { PaginationComponent } from './components/pagination/pagination.componen
 OcticonsDirective,
 FilterDropdownComponent,
 PaginationComponent,
 RepoIssuePullCardComponent,
 ],
})
export class SharedModule {}

2 changes: 2 additions & 0 deletions
angular-ngrx-scss/src/app/shared/styles/variables.scss

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,8 @@ $blue100: rgb(219, 234, 254);
$blue300: rgb(59, 130, 246);
$blue400: rgb(96, 165, 250);
$blue600: rgb(37 99 235);
$green100: rgb(5, 150, 105);
$purple100: rgb(124, 58, 237);

// breakpoints
$sm: 640px;
Expand Down