Skip to content

[Angular - NgRx - SCSS] 440: state & service refactor - #527

Merged
lindakatcodes merged 17 commits into
mainfrom
440/state-service-refactor
Nov 3, 2022
Merged

[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom
440/state-service-refactor

Conversation

@lindakatcodes

@lindakatcodeslindakatcodes commented Aug 20, 2022

Copy link
Copy Markdown
Contributor

Resolves#440

@lindakatcodeslindakatcodes self-assigned this Aug 20, 2022
@aws-amplify-us-east-1

aws-amplify-us-east-1Bot commented Aug 20, 2022

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com

@aws-amplify-us-east-1

aws-amplify-us-east-1Bot commented Aug 20, 2022

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com

@lindakatcodes
lindakatcodesforce-pushed the 440/state-service-refactor branch 2 times, most recently from c4642e8 to e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1

aws-amplify-us-east-1Bot commented Sep 2, 2022

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com

@lindakatcodes
lindakatcodesforce-pushed the 440/state-service-refactor branch from f6fda4b to 4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes

lindakatcodes commented Sep 23, 2022

Copy link
Copy Markdown
ContributorAuthor

This part of the refactor is focused on:

  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes

This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.

@lindakatcodes
lindakatcodesforce-pushed the 440/state-service-refactor branch from df180ec to c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz reviewed Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts Outdated
Comment threadangular-ngrx-scss/src/app/app.module.ts Outdated
Comment threadangular-ngrx-scss/src/app/home/home.component.ts Outdated
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts Outdated
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts Outdated
@lindakatcodes

lindakatcodes commented Oct 15, 2022

Copy link
Copy Markdown
ContributorAuthor

This has now been rebased and is as updated as I can get it - the site still works as expected.

There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.

Also I got most of the test files adjusted, but I've still got 4 failing tests:

  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should

The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.

@lindakatcodes
lindakatcodes marked this pull request as ready for review October 15, 2022 00:37
ktrz
ktrz suggested changes Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts Outdated
Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts Outdated
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts Outdated
Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts Outdated
Comment threadangular-ngrx-scss/src/app/app.module.ts Outdated
Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT added 13 commits October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed the 440/state-service-refactor branch from ca1a368 to 8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz reviewed Nov 3, 2022
View reviewed changes

@ktrzktrz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts Outdated
Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz approved these changes Nov 3, 2022
View reviewed changes

@ktrzktrz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@lindakatcodes
lindakatcodes merged commit dc70a37 into mainNov 3, 2022
@lindakatcodes
lindakatcodes deleted the 440/state-service-refactor branch November 3, 2022 22:06
hdJerry pushed a commit that referenced this pull request Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit that referenced this pull request Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit that referenced this pull request Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit that referenced this pull request Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit that referenced this pull request Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit that referenced this pull request Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit that referenced this pull request Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit that referenced this pull request Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring

3 participants

@lindakatcodes@ktrz@ihardz
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[Angular - NgRx - SCSS] 440: state & service refactor by lindakatcodes · Pull Request #527 · thisdot/starter.dev-github-showcases · GitHub
Skip to content
[Angular - NgRx - SCSS] 440: state & service refactor - #527
Merged
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Nov 3, 2022
Merged
[Angular - NgRx - SCSS] 440: state & service refactor#527
lindakatcodes merged 17 commits into
mainfrom 
440/state-service-refactor
Conversation
@lindakatcodes
@lindakatcodeslindakatcodes
commented
Aug 20, 2022

Copy link


Copy Markdown

Contributor
Resolves#440
@lindakatcodeslindakatcodes
self-assigned this
Aug 20, 2022
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d1190gmno2hljg.amplifyapp.com
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Aug 20, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.d3sqkonra6x7y9.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
2 times, most recently
from
c4642e8 to
e2412bfCompareSeptember 2, 2022 19:17
@aws-amplify-us-east-1
aws-amplify-us-east-1Bot
commented
Sep 2, 2022

Copy link


Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-527.dbm2zhgk5abrj.amplifyapp.com
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
f6fda4b to
4d02b33CompareSeptember 16, 2022 21:59
@lindakatcodes
lindakatcodes
commented
Sep 23, 2022

Copy link


Copy Markdown

ContributorAuthor
This part of the refactor is focused on:
  • adjusting services to return the full data from the API
  • adjusting state files to shape the data into what we expect to get back
  • initial setup of the new dashboard state files
  • any small changes needed to ensure the app still works and functions exactly how it should after the cleanup changes
This does still need to be rebased, but will have to hold for awhile since the files that are conflicting will need some thorough review to match the point of this refactor.
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
df180ec to
c3fb68dCompareOctober 14, 2022 01:12
ihardz
ihardz
reviewed
Oct 14, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

@lindakatcodes
lindakatcodes
commented
Oct 15, 2022

Copy link


Copy Markdown

ContributorAuthor
This has now been rebased and is as updated as I can get it - the site still works as expected.
There is still work to do with the repository services - some things got duplicated and it's a bit too messy even with this refactor to completely unify everything, so there's a bit of overlap between some of the service calls. I unified them as best as I could, but future work would be helpful here.
Also I got most of the test files adjusted, but I've still got 4 failing tests:
  • UserEffects: the user gists test doesn't equal what it should
  • UserEffects: get user info from API has an undefined error, I'm guessing from setting up the mock store but no mock data so this could (hopefully) be easily fixed
  • RepositoryService: info on provided repository doesn't equal what it should
  • UserService: user data from API doesn't equal what it should
The 3 tests that don't seem to match visually look like they do, so perhaps it's something minor somewhere that's mixed up. Needs a bit more checking to be sure.
@lindakatcodes
lindakatcodes
marked this pull request as ready for review
October 15, 2022 00:37
ktrz
ktrz
suggested changes
Oct 18, 2022
View reviewed changes
Comment threadangular-ngrx-scss/src/app/file-viewer/file-explorer-blob/file-explorer-blob.component.spec.ts
Comment threadangular-ngrx-scss/src/app/home/home.component.ts
Outdated

Comment threadangular-ngrx-scss/src/app/pull-requests/pull-requests.component.spec.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.spec.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/app.reducer.ts
Comment threadangular-ngrx-scss/src/app/user/services/user.service.ts
Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
Outdated

Comment threadangular-ngrx-scss/src/app/app.module.ts
LindaT
added 13 commits
October 21, 2022 16:48
LindaT
setup: get branch caught up and ready for work
d3e631b
LindaT
feat: refactored repository service and test
838fe53
LindaT
feat: refactor of user service and test
51f1a0f
LindaT
feat: updated user service spec
5b39d92
LindaT
feat: created dashboard store files; updated global state files; rena…
930342e
…med RepoState and updated all calls
LindaT
attempt to fix issues with service updates; some refactoring and adju…
4fddc75
…sting so app compiles
LindaT
feat: added auth user data to auth state; updated nav component to us…
9252dc0
…e auth state
LindaT
feat: adjusted auth call; fixed user call so home page loads
27a7882
LindaT
moved some user logic; still having reload issues and repo view issues
88dffe8
LindaT
feat: got app working again! cleaned out console logs
28e7fb6
LindaT
rebased and fixed most files
852ba69
LindaT
fix broken tests
9a33f67
LindaT
removed unused code
8051cf5
@lindakatcodes
lindakatcodesforce-pushed
the
440/state-service-refactor
branch
from
ca1a368 to
8051cf5CompareOctober 21, 2022 21:48
ktrz
ktrz
reviewed
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of housekeeping comments to make sure we have everything that we've discussed captured in tickets
Comment threadangular-ngrx-scss/src/app/state/auth/auth.effects.ts
Outdated

Comment threadangular-ngrx-scss/src/app/state/repository/repository.selectors.ts
Comment threadangular-ngrx-scss/src/app/repository/services/repository.service.ts
Comment threadangular-ngrx-scss/src/app/state/profile/profile.effects.ts
ktrz
ktrz
approved these changes
Nov 3, 2022
View reviewed changes
@ktrzktrz
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
@lindakatcodes
lindakatcodes
merged commit dc70a37
into
mainNov 3, 2022
@lindakatcodes
lindakatcodes
deleted the

440/state-service-refactor

branch
November 3, 2022 22:06
hdJerry pushed a commit
that referenced
this pull request
Nov 16, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
9e7b374
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
6f21c5c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
01f3cbe
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
8dd813c
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry pushed a commit
that referenced
this pull request
Nov 17, 2022
@lindakatcodesLindaT@hdJerry
[Angular - NgRx - SCSS] 440: state & service refactor (#527)
c212b8b
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@mbicknese@lindakatcodes
LindaT@SDaian@asincole@hdJerry@vyktoremario
[SolidJS-Tailwind] Implement authentication (#734)
eee2cb2
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
hdJerry added a commit
that referenced
this pull request
Nov 17, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod] Get all repositories from GitHub API#684 (#845)
04d1158
* in progress
* chore: get all repos api
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* auth token added to header
* ..updates
* ..updates
* auth token added to header
* fix file issues
* CI adjustments
* CI adjustments
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry added a commit
that referenced
this pull request
Nov 18, 2022
@hdJerry@lindakatcodes
LindaT@SDaian@asincole@vyktoremario@mbicknese
[solidjs-pod]: Get Gists from GitHub API (#838)
14d3c69
* chore: get gists api
* updated gists api function
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* [solidjs-pod] : Create component for search input and filter sort buttons (#831)
* in progress
* in progress
* in progress, paused for now
* chore: search filter sort component
* fixed comments on icons
* [solidjs-tailwinf] Add user profile card (#830)
* [SolidJS-Tailwind] Implement authentication (#734)
* chore(solidjs): remove example components
* feat(solidjs): add signin page
* refactor(solidjs): improve auth setup
* feat(solidjs): pencil in auth flow
* feat(solidjs): add example github communication
* [Angular - NgRx - SCSS] 440: state & service refactor (#527)
* setup: get branch caught up and ready for work
* feat: refactored repository service and test
* feat: refactor of user service and test
* feat: updated user service spec
* feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls
* attempt to fix issues with service updates; some refactoring and adjusting so app compiles
* feat: added auth user data to auth state; updated nav component to use auth state
* feat: adjusted auth call; fixed user call so home page loads
* moved some user logic; still having reload issues and repo view issues
* feat: got app working again! cleaned out console logs
* rebased and fixed most files
* fix broken tests
* removed unused code
* fix: fix pr comments and most tests
* fix: fixed final broken unit test
* fix: updated test; removed unused code in user effect; new user mapping file
* add todo for refactor improvements; update authUser effect to use different rxjs operation
Co-authored-by: LindaT <linda@thisdot.co>
* feat(solidjs) - Create navigation header (#840)
* fix(angular-apollo-tailwind): append protocol if missing from user url (#637)
* fix(angular-apollo-tailwind): append protocol if missing from user url
Refs: #591
* test(angular-apollo-tailwind): update with testcases
Closes: #591
* chore: repo card with story and test (#737)
* chore: repo card with story and test
* fix comments
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: gist panel UI (#741)
* chore: gist panel UI
* fix coment
* fix coment
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore(solidjs): remove example components
* fixed comments, clean ups
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
* chore: updated amplify.yml file (#729)
* chore: updated amplify.yml file
* changed pnpm to npm
* chore: workflow added (#745)
* chore: workflow added
* CI setup fixes and testing
* CI setup fixes and testing
* CI setup fixes and testing
* tried everything but doesn't work, i think we have to merge this
* ..updates
* ..updates
* ..updates
* added auth token
* added auth token
Co-authored-by: Linda Thompson <lindakt16@gmail.com>
Co-authored-by: LindaT <linda@thisdot.co>
Co-authored-by: Daian Scuarissi <scuarissid@gmail.com>
Co-authored-by: Oluwakorede Cole <asincole@gmail.com>
Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>
Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


2 more reviewers

@ihardzihardzihardz left review comments
@ktrzktrzktrz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lindakatcodeslindakatcodes

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[Angular - NgRx - SCSS] Refactor of Services, Prep for state restructuring


3 participants

@lindakatcodes@ktrz@ihardz