Skip to content

[express-apollo-prisma] Final cleanup from demo feedback - #1207

Open
iansamz wants to merge 19 commits into
mainfrom
fix/1202-cleanup
Open

[express-apollo-prisma] Final cleanup from demo feedback#1207
iansamz wants to merge 19 commits into
mainfrom
fix/1202-cleanup

Conversation

@iansamz

@iansamziansamz commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Documentation change
  • Bug fix

Summary of change

  • GraphQL naming conventions
  • Update README and link to accompanying blog post explaining limitations (Will be updated when blog is ready)
  • Clean up the scripts (yarn start, yarn test etc)
  • Fix linting issues (exclude .yaml files)
  • .env globally available with running queue (optional)

Checklist

@iansamz
iansamz requested a review from mbickneseMarch 27, 2023 12:09
@netlify

netlifyBot commented Mar 27, 2023•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for starter-dev canceled.

NameLink
🔨 Latest commit414255a
🔍 Latest deploy loghttps://app.netlify.com/sites/starter-dev/deploys/642c3023ddc2af0008473d9c

mbicknese
mbicknese suggested changes Mar 28, 2023
View reviewed changes
Comment threadstarters/express-apollo-prisma/.editorconfig Outdated
Comment threadstarters/express-apollo-prisma/src/graphql/schema/technology/technology.typedefs.ts Outdated
@mbicknese

mbicknese commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

starter.dev/starters/express-apollo-prisma/src/graphql/mappers/technology.ts

Line 18 in 314dab5

items: entityCollectionPage.items.map(mapTechnology),

Still refers to items

mbicknese
mbicknese suggested changes Mar 30, 2023
View reviewed changes

@mbicknesembicknese left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to work on this branch, but there are more changes required throughout the code to make the new types work. Can you do a sweep to find all outdated code?

@iansamziansamz self-assigned this Apr 4, 2023
kodejuice
kodejuice reviewed Apr 4, 2023
View reviewed changes
Comment threadstarters/express-apollo-prisma/.editorconfig Outdated
@sonarqubecloud

sonarqubecloudBot commented Apr 4, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

No Coverage information No Coverage information
0.0%0.0% Duplication

ihardz
ihardz approved these changes May 26, 2023
View reviewed changes

@ihardzihardz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iansamz , resolve conflicts and merge. Looks good!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyktoremariovyktoremariovyktoremario approved these changes
+3 more reviewers
@mbicknesembicknesembicknese approved these changes
@kodejuicekodejuicekodejuice approved these changes
@ihardzihardzihardz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@iansamziansamz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[express-apollo-prisma] Final cleanup from demo feedback

5 participants

@iansamz@mbicknese@kodejuice@ihardz@vyktoremario