Skip to content

fix: respect theme(strip.placement) when strip position is ambiguous - #447

Open
Yunuuuu wants to merge 1 commit into
thomasp85:mainfrom
Yunuuuu:strip_outside
Open

fix: respect theme(strip.placement) when strip position is ambiguous#447
Yunuuuu wants to merge 1 commit into
thomasp85:mainfrom
Yunuuuu:strip_outside

Conversation

@Yunuuuu

Copy link
Copy Markdown

fix#446

This PR ensures that add_strips() respects the strip.placement setting in the theme.

library(ggplot2)
set_theme(theme_classic() + theme(strip.placement="outside"))
p1<- ggplot(mtcars) + geom_point(aes(mpg, disp))
p2<- ggplot(mtcars) + geom_boxplot(aes(gear, disp, group=gear))
p3<- ggplot(mtcars) + geom_bar(aes(gear)) + facet_wrap(~cyl)
p1/ (p3|p2)
image

@Yunuuuu

Copy link
Copy Markdown
Author

I’m not sure why the PR failed the GitHub Actions check, since it succeeds on my local machine. I also noticed that all tests were already failing before this PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alignment difficulties with theme(strip.placement = "outside")

1 participant

@Yunuuuu