Skip to content

perf: use WellKnownTypes in AttributeWriter - #4623

Merged
thomhurst merged 1 commit into
thomhurst:mainfrom
TimothyMakkison:well_known_types
Jan 31, 2026
Merged

perf: use WellKnownTypes in AttributeWriter#4623
thomhurst merged 1 commit into
thomhurst:mainfrom
TimothyMakkison:well_known_types

Conversation

@TimothyMakkison

Copy link
Copy Markdown
Contributor

Use WellKnownTypes to cache ToDisplayName and GetTypeByMetadataName calls in AttributeWriter

Before

MethodMeanErrorStdDevMedianGen0Gen1Allocated
Compile225.6 ms10.50 ms29.45 ms210.0 ms11000.00004000.0000104.79 MB

After

MethodMeanErrorStdDevMedianGen0Gen1Allocated
Compile201.8 ms8.24 ms22.97 ms191.4 ms10000.00004000.000099.34 MB

@claude

claudeBot commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@thomhurst
thomhurst merged commit 0f9609a into thomhurst:mainJan 31, 2026
8 of 10 checks passed
This was referenced Feb 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison@thomhurst