perf: make StaticPropertyInitializationGenerator incremental - #4638
Merged
thomhurst merged 1 commit intoFeb 6, 2026
Merged
Conversation
TimothyMakkisonforce-pushed
the
static_prop_generator_incre
branch
from
February 1, 2026 17:35
3e61587 to
b2ae4c2CompareTimothyMakkison
marked this pull request as draft
February 1, 2026 17:41
TimothyMakkisontemporarily deployed
to
Pull Requests
February 1, 2026 18:14 — with
GitHub Actions
Inactive
TimothyMakkisonhad a problem deploying
to
Pull Requests
February 1, 2026 18:14 — with
GitHub Actions
Failure
TimothyMakkisontemporarily deployed
to
Pull Requests
February 1, 2026 18:14 — with
GitHub Actions
Inactive
TimothyMakkisonforce-pushed
the
static_prop_generator_incre
branch
from
February 3, 2026 17:52
b2ae4c2 to
91c570bCompareTimothyMakkisontemporarily deployed
to
Pull Requests
February 3, 2026 18:52 — with
GitHub Actions
Inactive
TimothyMakkisontemporarily deployed
to
Pull Requests
February 3, 2026 18:52 — with
GitHub Actions
Inactive
TimothyMakkisonhad a problem deploying
to
Pull Requests
February 3, 2026 18:52 — with
GitHub Actions
Failure
ContributorAuthor
Time and memory usage seems suspiciously low 🤔 but the tests appear to pass |
TimothyMakkison
marked this pull request as ready for review
February 3, 2026 21:50
TimothyMakkisonforce-pushed
the
static_prop_generator_incre
branch
2 times, most recently
from
February 5, 2026 00:26
486c58e to
4ccfdb3CompareTimothyMakkisontemporarily deployed
to
Pull Requests
February 5, 2026 00:34 — with
GitHub Actions
Inactive
TimothyMakkisontemporarily deployed
to
Pull Requests
February 5, 2026 00:34 — with
GitHub Actions
Inactive
TimothyMakkisonhad a problem deploying
to
Pull Requests
February 5, 2026 00:34 — with
GitHub Actions
Failure
TimothyMakkisonforce-pushed
the
static_prop_generator_incre
branch
from
February 5, 2026 23:02
4ccfdb3 to
9d6a975CompareTimothyMakkisonhad a problem deploying
to
Pull Requests
February 6, 2026 07:57 — with
GitHub Actions
Failure
TimothyMakkisontemporarily deployed
to
Pull Requests
February 6, 2026 07:57 — with
GitHub Actions
Inactive
TimothyMakkisontemporarily deployed
to
Pull Requests
February 6, 2026 07:57 — with
GitHub Actions
Inactive
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. This is a well-structured performance optimization that properly implements incremental source generation patterns. The separation of parsing and generation phases, introduction of value-based model types, and proper use of EquatableArray all follow Roslyn best practices for incremental generators. |
thomhurst
enabled auto-merge (squash)
February 6, 2026 08:16
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 6, 2026
This was referenced Mar 9, 2026
This was referenced Mar 16, 2026
This was referenced Mar 25, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertyWithDataSourceModeland associated typesImmutableArray<PropertyWithDataSource>fromGetSemanticTargetForGenerationenabledProvidercheck to earlier in pipeline to reduce workToUniquePropertyModelsensures that only distinct properties are converter intoPropertyWithDataSourceModelGetStaticPropertyDataSourcesinstead of doing a unnecessary call inGenerateStaticPropertyInitialization