fix: handle duplicate type names across assemblies in InfrastructureGenerator - #4664
Merged
Conversation
thomhursttemporarily deployed
to
Pull Requests
February 4, 2026 22:34 — with 
GitHub Actions
Inactive
thomhursthad a problem deploying
to
Pull Requests
February 4, 2026 22:34 — with GitHub Actions
Failure
thomhursttemporarily deployed
to
Pull Requests
February 4, 2026 22:34 — with GitHub Actions
Inactive
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. The fix correctly handles duplicate type names across assemblies by using Roslyn's
|
…enerator Fixes#4663 When multiple assemblies define types with the same fully-qualified name (e.g., ServiceCollectionExtensions in both AWSSDK.Extensions.NETCore.Setup and Amazon.Lambda.AspNetCoreServer.Hosting), the generated typeof() call caused CS0433 compilation errors. The fix uses Roslyn's GetTypeByMetadataName() to detect ambiguous types and skip them, finding a unique type from each assembly instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
thomhurstforce-pushed
the
fix/duplicate-type-names-4663
branch
from
February 4, 2026 22:39
3202968 to
57f661cComparethomhursttemporarily deployed
to
Pull Requests
February 4, 2026 22:39 — with GitHub Actions
Inactive
thomhursthad a problem deploying
to
Pull Requests
February 4, 2026 22:39 — with GitHub Actions
Failure
thomhursttemporarily deployed
to
Pull Requests
February 4, 2026 22:39 — with GitHub Actions
Inactive
thomhurst
enabled auto-merge (squash)
February 4, 2026 22:48
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 5, 2026
This was referenced Mar 6, 2026
This was referenced Mar 16, 2026
This was referenced Mar 23, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes#4663
ServiceCollectionExtensionsin bothAWSSDK.Extensions.NETCore.SetupandAmazon.Lambda.AspNetCoreServer.Hosting), the generatedtypeof()call caused CS0433 compilation errorsGetTypeByMetadataName()to detect ambiguous types and skip them, finding a unique type from each assembly insteadTest plan
DuplicateTypeNameAcrossAssembliesTestsverifies the generator skips ambiguous types🤖 Generated with Claude Code