fix: Update missed STAThread snapshot files with GeneratedCode attributes - #4693
Merged
Conversation
…ataGenerator output Co-authored-by: thomhurst <30480171+thomhurst@users.noreply.github.com>
…dCode attributes The original PR only updated DotNet9_0 variants but missed DotNet8_0, DotNet10_0, and Net4_7 framework-specific snapshot files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…utes The PR #4690 missed updating the STAThreadTests snapshot files when adding [ExcludeFromCodeCoverage] and [GeneratedCode] attributes to source generator output, causing the Windows CI pipeline to fail on snapshot verification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thomhursttemporarily deployed
to
Pull Requests
February 6, 2026 19:01 — with
GitHub Actions
Inactive
thomhursthad a problem deploying
to
Pull Requests
February 6, 2026 19:01 — with
GitHub Actions
Failure
thomhursttemporarily deployed
to
Pull Requests
February 6, 2026 19:01 — with
GitHub Actions
Inactive
thomhurst
enabled auto-merge (squash)
February 6, 2026 19:11
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 6, 2026
Closed
This was referenced Mar 9, 2026
This was referenced Mar 16, 2026
This was referenced Mar 25, 2026
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[ExcludeFromCodeCoverage]and[GeneratedCode]attributes to TestMetadataGenerator output but missed the 4 STAThread snapshot filesVerification failed for 'STAThreadTests.Test.DotNet10_0'.verified.txtfiles (DotNet10_0, DotNet9_0, DotNet8_0, Net4_7) with the same attribute additionsTest plan
modularpipeline (windows-latest)passes (specificallyRunSourceGeneratorTestsModule)🤖 Generated with Claude Code