chore(deps): update dependency dotnet-sdk to v10 - #6803
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe CodeQL and locale build workflows now install .NET SDK Changes.NET SDK workflow updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The workflows now consistently select the repository’s required .NET SDK version, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads each line, Comment |
Greptile SummaryThis PR updates the .NET SDK installed by two GitHub Actions workflows to 10.0.401.
Confidence Score: 5/5The PR appears safe to merge, although the two previously reported non-blocking workflow-maintenance issues remain unresolved. No new actionable failure was found. The locale workflow still performs three consecutive .NET 10 setup steps under distinct version labels, and the CodeQL workflow still labels its .NET 10 installation as “Setup .NET 9”; both outstanding previous findings are non-blocking maintenance concerns. Files Needing Attention: .github/workflows/codeql.yml, .github/workflows/dotnet-build-different-locale.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/codeql.yml | Updates the configured SDK to 10.0.401; the previously reported inaccurate step label remains. |
| .github/workflows/dotnet-build-different-locale.yml | Updates the former .NET 8 and .NET 9 setup steps to 10.0.401; the previously reported duplicate setup steps remain. |
Reviews (2): Last reviewed commit: "chore(deps): update dependency dotnet-sd..." | Re-trigger Greptile
| dotnet-version: 10.0.401 | ||
|
|
||
| - name: Setup .NET 9 | ||
| uses: actions/setup-dotnet@v6.0.0 | ||
| with: | ||
| dotnet-version: 9.0.x | ||
| dotnet-version: 10.0.401 |
There was a problem hiding this comment.
The steps labeled “Setup .NET 8” and “Setup .NET 9” now both install .NET 10 immediately before another .NET 10 setup step. Because the workflow performs only one multi-targeted build, these duplicate actions do not exercise the older SDKs or provide independent coverage. They also add unnecessary CI setup work and make the tested environment misleading. Restore the distinct versions if this coverage is intentional, or consolidate the steps and update their names.
| uses: actions/setup-dotnet@v6.0.0 | ||
| with: | ||
| dotnet-version: 9.0.x | ||
| dotnet-version: 10.0.401 |
There was a problem hiding this comment.
This step now installs .NET 10, but its name still says “Setup .NET 9.” Workflow logs therefore identify the wrong SDK, which can confuse future debugging and maintenance. Rename the step to match the configured SDK version.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1d4a29f to
9a6ec67
Compare
This PR contains the following updates:
9.0.x→10.0.4018.0.x→10.0.401Release Notes
dotnet/sdk (dotnet-sdk)
v10.0.401: .NET 10.0.12Compare Source
Release
What's Changed
dotnet newto suggest@instead of deprecated::separator in update notifications by @marcpopMSFT with @Copilot in #51153--nologoadheres to DOTNET_NOLOGO if present by @baronfel in #51462#:projectdirectives by @jjonescz in #51108Spectre.Consoleby @jonathanpeppers in #51859\\by @Youssef1313 in #51791Environment.GetFolderPathby @jjonescz in #51854MissingTestSessionEndwhen the exit code is already non-success by @Youssef1313 in #51857dotnet formatby @JoeRobich in #51697dotnet file.csinvocations by @jjonescz in #52110#:projectdirectives by @jjonescz in #52062dotnet run -by @jjonescz in #52132PlatformNotSupportedExceptionon various platforms by @github-actions[bot] in #523552873125by @dotnet-bot in #52171NullReferenceExceptionby @jonathanpeppers in #523672879817by @dotnet-bot in #52479PosixSignalRegistrationby @jonathanpeppers in #52466dotnet runby @jonathanpeppers in #526082891567by @dotnet-bot in #527472893098by @dotnet-bot in #52766dotnet run -e FOO=BARpasses@(RuntimeEnvironmentVariable)by @jonathanpeppers in #526642902832by @dotnet-bot in #53009$(Device)global property missing duringDeployToDevicetarget by @jonathanpeppers in #53018#:includeby @jjonescz in #523472912121by @dotnet-bot in #531232914767by @dotnet-bot in #53195Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate CLI.