Skip to content

Limit packaging to <22 - #489

Merged
harshad16 merged 1 commit into
thoth-station:masterfrom
VannTen:fix/packaging_version
Jan 12, 2023
Merged

Limit packaging to <22#489
harshad16 merged 1 commit into
thoth-station:masterfrom
VannTen:fix/packaging_version

Conversation

@VannTen

Copy link
Copy Markdown
Member

Temp fix

Related Issues and Dependencies

thoth-station/adviser#2404
thoth-station/adviser#2405

Context : pypa/packaging#321

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

Description

Stop-gap fix. We'll need to adpat to packaging version >21 eventually

@VannTenVannTen mentioned this pull request Jan 11, 2023

@harshad16harshad16 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the same change here as well

packaging

so that other modules using thoth-station/python
don't override the packaging version.

@VannTen

VannTen commented Jan 11, 2023 via email

Copy link
Copy Markdown
MemberAuthor

@harshad16

Copy link
Copy Markdown
Member

Can we get rid of requirements.txt and use setuptools-pipfile to avoid having two files to maintain ?

yeah sounds good

@harshad16harshad16 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 👍

@seshetasesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@sesheta

Copy link
Copy Markdown
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seshetasesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@harshad16
harshad16 merged commit 4a55e80 into thoth-station:masterJan 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@VannTen@harshad16@sesheta