Skip to content

[close #782] bump grpc to 1.60.0 - #783

Merged
iosmanthus merged 2 commits into
tikv:masterfrom
iosmanthus:bump-grpc-to-1.60.0
Mar 28, 2024
Merged

[close #782] bump grpc to 1.60.0#783
iosmanthus merged 2 commits into
tikv:masterfrom
iosmanthus:bump-grpc-to-1.60.0

Conversation

@iosmanthus

@iosmanthusiosmanthus commented Mar 28, 2024

Copy link
Copy Markdown
Member

What problem does this PR solve?

This pull request bumps the gRPC version to 1.60.0 as the same deps of jetcd 0.7.7. Might related to grpc/grpc-java#9340

I can reproduce the memory leak while using gRPC 1.48.0 as described in issue #782. When I bump the gRPC to 1.60.0 the error logs disappear even I run the test 100 times.

Issue Number: close#782

What has changed and how does it work?

Bump the gRPC version to 1.60.0.

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
pingyu
pingyu previously approved these changes Mar 28, 2024

@pingyupingyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@codecov

codecovBot commented Mar 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 34.81%. Comparing base (0af4384) to head (34fde17).

FilesPatch %Lines
...java/org/tikv/common/region/RegionStoreClient.java0.00%6 Missing ⚠️
src/main/java/org/tikv/common/PDClient.java0.00%5 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #783 +/- ##
============================================
- Coverage 34.98% 34.81% -0.17% + Complexity 1362 1354 -8 
============================================
Files 266 266 Lines 14274 14283 +9 Branches 1606 1606 ============================================
- Hits 4994 4973 -21 - Misses 8845 8873 +28 - Partials 435 437 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iosmanthus
iosmanthus enabled auto-merge (squash) March 28, 2024 08:33
@iosmanthus
iosmanthus merged commit ca8a622 into tikv:masterMar 28, 2024
jackjeyis pushed a commit to jackjeyis/client-java that referenced this pull request Jun 3, 2024
Signed-off-by: b.tian <b.tian@trip.com>
shiyuhang0 added a commit that referenced this pull request Jun 4, 2024
…ervice(#774) (#775)
* add TwoPhaseCommitter new Constructor contains executorService(#774)
Signed-off-by: b.tian <b.tian@trip.com>
* [close#671] remove shadowing of netty && grpc (#781)
Signed-off-by: b.tian <b.tian@trip.com>
* [close#782] bump grpc to 1.60.0 (#783)
Signed-off-by: b.tian <b.tian@trip.com>
* [close#774]remove redundant code
---------
Signed-off-by: b.tian <b.tian@trip.com>
Co-authored-by: b.tian <b.tian@trip.com>
Co-authored-by: iosmanthus <dengliming@pingcap.com>
Co-authored-by: shi yuhang <52435083+shiyuhang0@users.noreply.github.com>
iosmanthus added a commit that referenced this pull request Apr 18, 2025
iosmanthus added a commit to iosmanthus/client-java that referenced this pull request Apr 18, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak while facing high pressure workload

2 participants

@iosmanthus@pingyu