Skip to content

Change the way schema ids are generated - #19

Closed
etaque wants to merge 5 commits into
timeoutdigital:masterfrom
dividat:fix-list-ids
Closed

Change the way schema ids are generated#19
etaque wants to merge 5 commits into
timeoutdigital:masterfrom
dividat:fix-list-ids

Conversation

@etaque

Copy link
Copy Markdown

This PR fixes two blocker for us:

  • Allow the use of lists at a top level by adding type args in ids.
  • Hide canonical names in ids to avoid exposing app internals.

We also bumped a few deps on top of #17

andrew-dominoand others added 5 commits March 5, 2018 12:01
This brings docless up to:
- cats 1.x
- circe 0.9
- sbt 1.1.x
Fixestimeoutdigital#16
Without this, lists as JsonSchema instances do share the same id, `scala.collection.immutable.List`
This also further upgrade dependencies.
@etaqueetaque closed this Oct 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@etaque@andrew-domino