Make compatible with python 3 - #248
Merged
Merged
Conversation
timotheus
commented
Sep 3, 2018
Owner
Thanks for the contribution. Apologies for the delay. |
w-
commented
Sep 4, 2018
ContributorAuthor
sweet. thx. any idea on when you will be creating a new release? |
timotheus
commented
Sep 4, 2018
via email
Owner
I’ll package and upload it tomorrow after I pull in one or two more fixes.
Tim …On Mon, Sep 3, 2018 at 8:14 PM w- ***@***.***> wrote:
sweet. thx. any idea on when you will be creating a new release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#248 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGoXwyGPJH1AXxedw5Vt8UdK2ty14caks5uXfAlgaJpZM4U3Upe>
.
|
Merged
timotheus
commented
Sep 5, 2018
Owner
I need to rollback this change. It's breaking existing code. https://github.com/timotheus/ebaysdk-python/blob/master/samples/finding.py#L69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#155