Uh oh!
There was an error while loading. Please reload this page.
add libXfont2 support with a compile-time switch - #13
Conversation
stefan11111
commented
Nov 14, 2024
while doing this, I also found that there is a function 'miImageGlyphBlt' in mi/miglblt.c, which is declared static(_X_EXPORT), only referenced in mi/mi.h, and never called anywhere. |
| #ifdef XFONT2 | ||
| FontShmdescIndex = xfont2_allocate_font_private_index(); | ||
| #else |
There was a problem hiding this comment.
since all xfont2 specific functions seem to behave identically, except for the name, i'd add a xfont2_compat.h which looks like
#ifdefXFONT2#defineAllocateFontPrivateIndex xfont2_allocate_font_private_index
...
#endifthat way the ifdefs are in a single place and not littered all over the code.
(one could also use function-like macros)
Implemented @rofl0r 's suggestion. Will open a new PR with everything squashed in one single commit. |
stefan11111
commented
Dec 19, 2024
Opened the new PR here: #14 |
Same as #12, but with a compile time switch between libXfont1 and libXfont2.
Defaults to libXfont1