port tinyx to libXfont2

[stefan11111]

While I could get tinyx to build with linXfont1 installed, I couldn't get tinyx to start on my machine with regular libXfont2 fonts installed.

So I ported tinyx to libXfont2.

[clbr]

We're currently using it with libXfont 1, so I'm not sure whether to take this change right now. Perhaps in the future. Thank you for submitting.

[stefan11111]

Also, something unrelated to the patch here.
I was looking through warnings and found some concerning things:

kdrive.c: In function 'KdParseMouse':
kdrive.c:514:20: warning: comparison of constant '44' with boolean expression is always true [-Wbool-compare]
514 | if (!delim != ',')
| ^~
kdrive.c:514:20: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
kdrive.c:514:13: note: add parentheses around left hand side expression to silence this warning
514 | if (!delim != ',')
| ^~~~~~
| ( )

Is this really how the above check is intended to be?

Also, some possible non-heap frees, but there might be bogus, as I haven't checked them.
Here's one of them:

In function 'miRegionBreak',
inlined from 'miUnion' at ../../mi/miregion.c:1145:13,
inlined from 'shadowReportFunc' at ../../miext/shadow/shadow.c:127:5:
../../mi/miregion.c:348:5: warning: 'free' called on unallocated object 'miBrokenData' [-Wfree-nonheap-object]
348 | xfreeData (pReg);
| ^
../../mi/miregion.c: In function 'shadowReportFunc':
../../mi/miregion.c:223:13: note: declared here
223 | RegDataRec miBrokenData = {0, 0};

[clbr]

On Mon, 04 Nov 2024 04:08:16 -0800 stefan11111 ***@***.***> wrote: Also, something unrelated to the patch here. I was looking through warnings and found some concerning things: ``` kdrive.c: In function 'KdParseMouse': kdrive.c:514:20: warning: comparison of constant '44' with boolean expression is always true [-Wbool-compare] 514 | if (!delim != ',') | ^~ kdrive.c:514:20: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] kdrive.c:514:13: note: add parentheses around left hand side expression to silence this warning 514 | if (!delim != ',') | ^~~~~~ | ( ) ``` Is this really how the above check is intended to be?

This looks buggy yeah, probably intended not to have the !

Also, some possible non-heap frees, but there might be bogus, as I haven't checked them. Here's one of them: ``` In function 'miRegionBreak', inlined from 'miUnion' at ../../mi/miregion.c:1145:13, inlined from 'shadowReportFunc' at ../../miext/shadow/shadow.c:127:5: ../../mi/miregion.c:348:5: warning: 'free' called on unallocated object 'miBrokenData' [-Wfree-nonheap-object] 348 | xfreeData (pReg); | ^ ../../mi/miregion.c: In function 'shadowReportFunc': ../../mi/miregion.c:223:13: note: declared here 223 | RegDataRec miBrokenData = {0, 0}; ```

This is not a bug, check the define of xfreeData.

[stefan11111]

On Mon, 04 Nov 2024 04:08:16 -0800 stefan11111 @.***> wrote: Also, something unrelated to the patch here. I was looking through warnings and found some concerning things: kdrive.c: In function 'KdParseMouse': kdrive.c:514:20: warning: comparison of constant '44' with boolean expression is always true [-Wbool-compare] 514 | if (!delim != ',') | ^~ kdrive.c:514:20: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] kdrive.c:514:13: note: add parentheses around left hand side expression to silence this warning 514 | if (!delim != ',') | ^~~~~~ | ( ) Is this really how the above check is intended to be?
This looks buggy yeah, probably intended not to have the !

Opened a new PR to fix this: #9