Uh oh!
There was an error while loading. Please reload this page.
docs(pii): land the #154 post-approval polish that missed the squash - #156
Conversation
…p two loose bare keywords Post-approval notes from tinyhumansai#154 review: the CJK-tier comment claimed the tier helps when digits directly follow a CJK word, but in exactly that case CC_RE's leading word-boundary already fails (CJK is a word character) and the run is never a candidate — the tier earns its place on keyword-embedded-in-sentence text. Also drop bare `elo` and `maestro` from the standalone keyword list: both networks are covered structurally by the IIN table, and as English words they are looser than the rest of the list.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe credit-card keyword matcher no longer treats ChangesPII matching
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to This change narrows standalone keyword matching while retaining structural detection for Maestro and Elo card numbers; it introduces no actionable merge-blocking risk and is merge-ready after normal checks. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
How this change flows0 changed behaviours across 7 relationships. 6 surrounding behaviours are shown (60 graph nodes walked). 17 further behaviours left out to keep the diagram readable. flowchart LR
n0["collect_redactions_inner"]:::impacted
n1["Hit"]:::impacted
n2["push"]:::impacted
n3["push_credit_cards"]:::impacted
n4["redact_pii"]:::impacted
n5["collect_redactions"]:::impacted
n0 -->|uses| n1
n0 -->|calls| n3
n3 -->|uses| n1
n3 -->|calls| n2
n4 -->|calls| n5
n5 -->|calls| n0
n5 -->|uses| n1
classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Green: changed behaviour. Grey: surrounding behaviour. Arrows name the call, use, implementation, or test relationship. Orange: has findings. Red: has a finding that blocks the merge. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
#154's squash was cut at
ef1eb19; the post-approval commitbfd2ea2— addressing @oxoxDev's approval notes — was pushed but never made it into the merge. This re-lands it on main, byte-identical (verified: zero content diff vsbfd2ea2).Two changes:
…信用卡账单 <PAN>) — and why digit-attached卡号<PAN>was never a candidate at all (CC_RE's leading\bfails on CJK-\w).eloandmaestrodropped from the standalone keyword list — both networks are covered structurally by the IIN table, and as English words they were the loosest entries.Docs + one regex literal; no behavior change beyond the two keywords narrowing. Safety suite 82 passed, fmt clean.
Follow-up once this merges: an openhuman
vendor/tinycortexre-pin from the now-orphanedbfd2ea2(a PR-head SHA openhuman main currently points at, reachable only viarefs/pull/154/head) to the resulting main SHA — restoring the fresh-clone reachability guarantee and closing the content drift between openhuman's pin and tinycortex main.🤖 Generated with Claude Code
Summary by CodeRabbit