Uh oh!
There was an error while loading. Please reload this page.
Pin an npm that can resolve the AgentMemory image - #87
Merged
YellowSnnowmann merged 1 commit intoAug 23, 2026
Merged
Conversation
`AgentMemory E2E` has been red on every branch since this afternoon, including `main`, where the commit it fails on touches no JavaScript. It went green at 10:47 and red at 15:39 with nothing between. The image ships npm 10.9.8, whose arborist dereferences null on this package.json: npm error Cannot read properties of null (reading 'edgesOut') It is the npm version, not the dependencies. npm 11.12.1 resolves the same file — copied out of the pinned tag — to 276 packages and exits 0. So the build installs an npm that works before using it. Pinned exactly rather than floated, because the reason this broke at all is that the build has no lockfile and resolves against a registry that moves underneath it; a floating `npm@11` would leave half of that non-determinism in place. The upstream tag ships no lockfile, so `npm ci` is not available here. That is the real fix and it is not ours to make.
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Warning Your free Security trial is over. An organization admin can activate billing to continue. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
YellowSnnowmann
marked this pull request as ready for review
August 23, 2026 17:10
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentMemory E2Eis red on every branch includingmain. This makes it green.package.json; a newer npm resolves the identical file fine.Problem
The job went green at
b645372(10:47) and red atcb58afb(15:39) the same day.cb58afbis the merge of #85, which touches no JavaScript, no Dockerfile and no compose file — and every PR branch fails it too.The failure is in the container build, before anything from this repo runs:
edgesOuton null is an npm arborist bug, and the log names the version: 10.9.8, whatnode:22-bookworm-slimships.Root cause, checked rather than assumed
I pulled
package.jsonfrom the pinned tag (rohitg00/agentmemory@v0.9.29) and ran it against a newer npm:So the dependency graph is resolvable. It is the npm version that cannot resolve it.
Two theories I checked and dropped, since they would have sent the next person the wrong way:
COPY package.jsonbeforeCOPY .is the classic workspaces-break-on-manifest-only-copy shape. Thispackage.jsondeclares noworkspaces, so that is not it.The
overridesblock (qs,ws,protobufjs) is the most likely thing arborist is tripping on, but the fix does not depend on which edge it is.Solution
Pinned exactly, not floated. The reason this broke without a commit is that the build has no lockfile and resolves against a registry that moves underneath it; a floating
npm@11would leave half that non-determinism in place.11.12.1is the version I actually verified, rather than the12.0.2the notice advertises and I have not run.What this does not fix. The upstream tag ships no lockfile, so
npm ciis not available. That is the real fix and it is not ours to make — this build will stay exposed to registry drift, just not to this particular npm bug.Testing
I cannot run this job locally (no Docker on this machine), so the honest statement of evidence is:
package.jsonfrom the pinned tag, exit 0, 276 packages.node:22-bookworm-slimon linux. Close, not identical — CI is the test.If it does not go green, the next thing to try is
node:24-bookworm-slim(the tag'senginesisnode >=20.0.0, so the base image can move).Related
Unblocks #86 and every other open PR in this repo. Independent of both — it is filed separately rather than folded into #86 because it shares no subject with it.