feat: added support for output when inherit is used

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think

[gperdomor]

This PR adds support for capturing stdout and stderr output even when stdio is set to "inherit".
Now, when stdio is "inherit", output is both displayed in the terminal and captured in the result object.

Fix#51

[gperdomor]

Hey @43081j can you take a look at this please... 🙏🏻

[43081j]

sorry, i have been meaning to take a look but got swamped with other things.

ill have a read through today 👍

[43081j]

so the summary is that you change inherit to pipe in order to capture the chunks, then re-emit them as if it was inherit

it does feel a bit awkward having to basically intercept inherited output.

im really not sure if we should be doing this, or if we should just be documenting the recipe for users. a user can do this today by piping the output through a stream they then pipe into process.stdout. i feel like it'd be better to just document that instead of mimicking inherit

[gperdomor]

documenting the use case with an example sounds good too

[43081j]

i think lets go with that so we don't have to deal with maintaining this pass-through. that way we can keep the underlying architecture a thin layer still

i can try update the docs if you don't have the time. let me know if you want to give it a go

basically just a section in the README would do i think