Skip to content

INT-3358: Remove @tinymce/miniature from dependency - #76

Merged
tiny-ben-tran merged 29 commits into
mainfrom
feature/INT-3358
Apr 14, 2026
Merged

INT-3358: Remove @tinymce/miniature from dependency#76
tiny-ben-tran merged 29 commits into
mainfrom
feature/INT-3358

Conversation

@tiny-ben-tran

@tiny-ben-trantiny-ben-tran commented Apr 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description of changes:

  • Move @tinymce/miniature to devDependency so that this library can stay open sourced
  • Added tests for disabled attribute.
  • Fixed changelog entry for disabled attribute
  • Fixed running demo with ts-node crashed
  • Converted LoadTest to BBD

@tiny-ben-tran
tiny-ben-tran requested review from a team, MitchC1999, TheSpyder, shanmen-tiny and soritaheng and removed request for a teamApril 1, 2026 03:20
@tiny-ben-tran
tiny-ben-tran requested a review from a team as a code ownerApril 1, 2026 03:21
@tiny-ben-tran
tiny-ben-tran requested review from ltrouton and removed request for a teamApril 1, 2026 03:21
TheSpyder
TheSpyder approved these changes Apr 1, 2026
View reviewed changes
Comment threadsrc/test/ts/alien/Utils.ts Outdated
Comment threadsrc/test/ts/browser/DisabledTest.ts Outdated
Comment threadsrc/demo/js/configs/full-config.js Outdated
soritaheng
soritaheng approved these changes Apr 1, 2026
View reviewed changes
Comment threadCHANGELOG.md Outdated
github-advanced-security[bot]
github-advanced-securityBot found potential problems Apr 6, 2026
View reviewed changes
Comment threadsrc/test/ts/browser/DisabledTest.ts Fixed
Comment threadsrc/test/ts/browser/DisabledTest.ts Fixed
jscasca
jscasca reviewed Apr 8, 2026
View reviewed changes
Comment threadsrc/test/ts/alien/Utils.ts Outdated
TheSpyder
TheSpyder approved these changes Apr 10, 2026
View reviewed changes
Comment threadsrc/test/ts/alien/Utils.ts
@tiny-ben-tran
tiny-ben-tran merged commit eaa9827 into mainApr 14, 2026
4 checks passed
@tiny-ben-tran
tiny-ben-tran deleted the feature/INT-3358 branch April 14, 2026 02:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheSpyderTheSpyderTheSpyder approved these changes
@MitchC1999MitchC1999Awaiting requested review from MitchC1999MitchC1999 was automatically assigned from tinymce/editor-platform-team
@shanmen-tinyshanmen-tinyAwaiting requested review from shanmen-tinyshanmen-tiny was automatically assigned from tinymce/editor-platform-team
@ltroutonltroutonAwaiting requested review from ltroutonltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers
@ArvinJ-HArvinJ-HAwaiting requested review from ArvinJ-H
@kimwoodfieldkimwoodfieldAwaiting requested review from kimwoodfield
@soritahengsoritahengAwaiting requested review from soritaheng
+2 more reviewers
@jscascajscascajscasca left review comments
@github-advanced-securitygithub-advanced-security[bot]github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tiny-ben-tran@TheSpyder@jscasca@github-advanced-security@soritaheng