Uh oh!
There was an error while loading. Please reload this page.
chore(deps-dev): bump jsdom to 30 and lint-staged to 17 - #686
Merged
Conversation
The last two majors from the Dependabot dev-dependencies group (#678). Both are dev-only -- jsdom is the test environment, lint-staged runs in the pre-commit hook -- and all nine `pnpm verify` checks pass, including the 172 web tests running under jsdom 30. Their breaking changes are almost entirely Node floors, which is the one thing worth recording: jsdom 30 ^22.22.2 || ^24.15.0 || >=26.0.0 lint-staged 17 >=22.22.1 Note that these are stricter than this repo's `devEngines.runtime.node`, which says `>=22`. Node 22.0.0 through 22.22.0 satisfies the repo but not these packages. CI is unaffected -- `node-version: '22'` resolves to the latest 22.x -- and pnpm does not enforce engines (engine-strict is off), so nothing fails at install. Tightening devEngines to match is a separate decision, since it would also rule out Node 24.0-24.14. lint-staged 17's other two breaks do not apply: the Git floor of 2.32.0 is from 2021, and `yaml` becoming optional only matters for YAML config files, while this repo keeps its lint-staged config in package.json. jsdom 30's remaining changes are additive or fixes: `CSS.escape()` and `CSS.supports()`, the `background-position-x`/`-y` properties, `getComputedStyle()` now converting lengths to pixels, and CSS function serialization. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two majors from the Dependabot dev-dependencies group (#678).
Both are dev-only -- jsdom is the test environment, lint-staged runs in the
pre-commit hook -- and all nine
pnpm verifychecks pass, including the 172web tests running under jsdom 30.
Their breaking changes are almost entirely Node floors, which is the one
thing worth recording:
jsdom 30 ^22.22.2 || ^24.15.0 || >=26.0.0
lint-staged 17 >=22.22.1
Note that these are stricter than this repo's
devEngines.runtime.node,which says
>=22. Node 22.0.0 through 22.22.0 satisfies the repo but notthese packages. CI is unaffected --
node-version: '22'resolves to thelatest 22.x -- and pnpm does not enforce engines (engine-strict is off), so
nothing fails at install. Tightening devEngines to match is a separate
decision, since it would also rule out Node 24.0-24.14.
lint-staged 17's other two breaks do not apply: the Git floor of 2.32.0 is
from 2021, and
yamlbecoming optional only matters for YAML config files,while this repo keeps its lint-staged config in package.json.
jsdom 30's remaining changes are additive or fixes:
CSS.escape()andCSS.supports(), thebackground-position-x/-yproperties,getComputedStyle()now converting lengths to pixels, and CSS functionserialization.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬