ci: skip workflows on docs-only changes - #30
Conversation
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/coverage-pages.yml (1)
6-13: Broaden workflow-file matching to avoid trigger drift.This filter only includes one workflow file. If the intent is to run on workflow changes generally, use a broader pattern.
♻️ Suggested change
- - '.github/workflows/coverage-pages.yml' + - '.github/workflows/**'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/coverage-pages.yml around lines 6 - 13, The workflow's paths filter explicitly lists only '.github/workflows/coverage-pages.yml', which will miss other workflow file changes and cause trigger drift; update the paths block (the list containing 'CMakeLists.txt', 'CMakePresets.json', ..., '.github/workflows/coverage-pages.yml') to use a broader pattern such as '.github/workflows/**' or include the appropriate wildcard(s) so changes to any workflow file will trigger this workflow instead of only coverage-pages.yml.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/coverage-pages.yml:
- Around line 6-13: The workflow's paths filter explicitly lists only
'.github/workflows/coverage-pages.yml', which will miss other workflow file
changes and cause trigger drift; update the paths block (the list containing
'CMakeLists.txt', 'CMakePresets.json', ...,
'.github/workflows/coverage-pages.yml') to use a broader pattern such as
'.github/workflows/**' or include the appropriate wildcard(s) so changes to any
workflow file will trigger this workflow instead of only coverage-pages.yml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c887dfe4-57e6-4467-afdf-6f420692b9a2
📒 Files selected for processing (2)
.github/workflows/coverage-pages.yml.github/workflows/pr-check.yml
Summary
pathsfilter topr-check.ymlandcoverage-pages.ymlso they only trigger on source, build config, or workflow file changes.mdfiles, etc.) no longer run the full build/test/coverage pipelineworkflow_dispatchis preserved for on-demand runsSummary by CodeRabbit