FABButton.propTypes does not contain Button.propTypes

[PavelPZ]

It seems that FABButton inherits all props from Button.
Are there any other examples of propTypes inheritance (I mentioned IconButton too)? If yes, I have to modify my TypeScript definition file generator.

[tleunen]

Will continue the typescript related questions on #266

[PavelPZ]

Is it really TypeScript question?

IconButton.js contains

IconButton.propTypes = {
    className: PropTypes.string,
    name: PropTypes.string.isRequired
};

Should not be (from button.js) like this?

IconButton.propTypes = {
        name: PropTypes.string.isRequired,
        accent: PropTypes.bool,
        className: PropTypes.string,
        colored: PropTypes.bool,
        component: PropTypes.oneOfType([
            PropTypes.string,
            PropTypes.element,
            PropTypes.func
        ]),
        href: PropTypes.string,
        primary: PropTypes.bool,
        raised: PropTypes.bool,
        ripple: PropTypes.bool
    };

[tleunen]

Indeed, because IconButton is basically a Button, it can also accepts all the props from Button.

The thing is, I don't think it makes sense to put them in the code. I think eslint will warn of unused props if it's the case. So maybe it's something that should only live in the typescript definition?

[PavelPZ]

You are right, I will include type inheritance to my generator for those cases:

• FABButton & IconButton inherits from the Button
• what else?