Skip to content

Add PHP to supported Language Map - #19

Merged
tobilg merged 1 commit into
tobilg:masterfrom
grantlucas:patch-1
Mar 24, 2019
Merged

Add PHP to supported Language Map#19
tobilg merged 1 commit into
tobilg:masterfrom
grantlucas:patch-1

Conversation

@grantlucas

Copy link
Copy Markdown
Contributor

I have an API that can be used by a variety of languages and it doesn't seem that I can specify PHP as a language. I believe this change will allow that?

As mentioned in Issue #18, it'd be nice to be able to specify a Widdershins config file instead to configure it instead of having to use api2html params.

@tobilg
tobilg merged commit a9a41bc into tobilg:masterMar 24, 2019
@tobilg

Copy link
Copy Markdown
Owner

Thanks for the PR. I just released version 0.3.1 of this package.

@grantlucas
grantlucas deleted the patch-1 branch March 24, 2019 18:34
Comment threadbin/api2html.js
"java": "Java",
"go": "Go"
"go": "Go",
"php: "PHP"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing " after "php which causes build failures with 0.3.1

/node_modules/api2html/bin/api2html.js:23
00:00:57.282 "php: "PHP"
00:00:57.282 ^^^
00:00:57.282 00:00:57.282 SyntaxError: Unexpected identifier
00:00:57.282 at new Script (vm.js:74:7)
00:00:57.282 at createScript (vm.js:246:10)
00:00:57.282 at Object.runInThisContext (vm.js:298:10)
00:00:57.282 at Module._compile (internal/modules/cjs/loader.js:670:28)
00:00:57.282 at Object.Module._extensions..js (internal/modules/cjs/loader.js:713:10)
00:00:57.282 at Module.load (internal/modules/cjs/loader.js:612:32)
00:00:57.282 at tryModuleLoad (internal/modules/cjs/loader.js:551:12)
00:00:57.282 at Function.Module._load (internal/modules/cjs/loader.js:543:3)
00:00:57.282 at Function.Module.runMain (internal/modules/cjs/loader.js:744:10)
00:00:57.282 at startup (internal/bootstrap/node.js:238:19)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be resolved when PR #20 is merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@grantlucas@tobilg@abelhegedus